Re: [PATCH v4 3/3] net: fsl_enetc: Add 1G SGMII mode support for i.MX95

Marek Vasut <[email protected]> Tue, 18 Aug 2026 11:14:22 +0200

Newsgroups	org.u-boot-project.lists.u-boot
Message-ID	<[email protected]>

On 8/18/26 5:18 AM, [email protected] wrote:

[...]

> @@ -565,6 +581,9 @@ static int enetc_config_phy(struct udevice *dev)
>   	if (enetc_is_imx95(dev))
>   		supported |= PHY_10G_FEATURES;
>   
> +	if (priv->uclass_id == PHY_INTERFACE_MODE_SGMII && enetc_is_imx95(dev))
> +		supported = PHY_1000BT_FEATURES | PHY_DEFAULT_FEATURES;

Shouldn't this be clearing out the supported features ?

supported &= ~(PHY_100BT_FEATURES | PHY_10BT_FEATURES);

>   	priv->phy->supported &= supported;
>   	priv->phy->advertising &= supported;
[...]