[PATCH v2 2/4] usb: ehci-vf: drop the empty bind hook
Mehmet Fide <[email protected]>
| Newsgroups | org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
From: Mehmet Fide <[email protected]> vf_usb_bind() only returns 0. Its comment describes a hack that keeps the second controller from taking sequence number 0, but no such code is there, and an empty .bind cannot influence the numbering the uclass does. Remove it. Fixes: 0885cdb9d154 ("usb: host: ehci-vf: Migrate Vybrid USB to driver model") Fixes: b27347f425f7 ("usb: Update for new sequence numbers") Signed-off-by: Mehmet Fide <[email protected]> --- drivers/usb/host/ehci-vf.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/usb/host/ehci-vf.c b/drivers/usb/host/ehci-vf.c index 5d27318de62..e5f9ec0fdbb 100644 --- a/drivers/usb/host/ehci-vf.c +++ b/drivers/usb/host/ehci-vf.c @@ -261,20 +261,6 @@ static const struct ehci_ops vf_ehci_ops = { .init_after_reset = vf_init_after_reset }; -static int vf_usb_bind(struct udevice *dev) -{ - /* - * Without this hack, if we return ENODEV for USB Controller 0, on - * probe for the next controller, USB Controller 1 will be given a - * sequence number of 0. This conflicts with our requirement of - * sequence numbers while initialising the peripherals. - * - * FIXME: Check that this still works OK with the new sequence numbers - */ - - return 0; -} - static int ehci_usb_probe(struct udevice *dev) { struct usb_plat *plat = dev_get_plat(dev); @@ -315,7 +301,6 @@ U_BOOT_DRIVER(ehci_vf) = { .name = "ehci_vf", .id = UCLASS_USB, .of_match = vf_usb_ids, - .bind = vf_usb_bind, .probe = ehci_usb_probe, .remove = ehci_deregister, .ops = &ehci_usb_ops, -- 2.54.0