Re: [PATCH v1 1/2] boot: android: Add Android 13+ bootflow support to bootmeth.

Tom Rini <[email protected]>
Newsgroups org.u-boot-project.lists.u-boot
Message-ID <20260820151021.GI523975@bill-the-cat>
On Thu, Aug 20, 2026 at 06:31:18AM -0600, Simon Glass wrote:
> Hi Valentin,
> 
> On 2026-08-18T17:53:00, Valentin Liu <[email protected]> wrote:
> > boot: android: Add Android 13+ bootflow support to bootmeth.
> 
> Please drop the trailing period and keep the subject under 60 characters.
> 
> >
> > The devices launching Android 13+ were using a new partition
> > named init_boot to store generic ramdisk.
> 
> >
> > In the new bootflow, kernel still be stored in boot image,
> > however, the First Stage files in ramdisk were moved to
> > init_boot image. We should load it to memory and verify it
> > so that the kernel can execute init program to continue booting.
> >
> > Currently, we have supported loading the init_boot image by
> > abootimg command, but we still need bring this ability to
> > bootmeth, so that booting Android 13+ will be more easily.
> 
> Please use present/imperative tense throughout: 'were using' -> 'use',
> 'kernel still be stored' -> 'the kernel is still stored', 'were moved'
> -> 'are moved', 'we still need bring' -> 'we still need to bring',
> 'more easily' -> 'easier'.

We do not have any sort of grammar rules and requirements like that in
the project, please stop giving people feedback like this.

-- 
Tom
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTzzqh0PWDgGS+bTHor4qD1Cr/kCgUCaocY2gAKCRAr4qD1Cr/k
Cln7AP9MDdIjkViv0GFYRFMZqfvn1v6VIh+Kgyxh1hCYXVvEgAEA0kDEv4hj+fJx
7P0dqBrma4KRflTXLXrbldkL/klfegA=
=voH7
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.