Re: [PATCH 0/2] efi_loader: fix GetRng() implementation

On Thu, Aug 20, 2026 at 03:07:44PM +0200, Heinrich Schuchardt wrote:
> Use EFI_PRINT() instead of debug() to correctly indent the message.
> 
> The return value of platform_get_rng_device() is efi_status_t.
> It does not fit into an integer variable ret. Use variable status.
> 
> We already write a debug message in platform_get_rng_device().
> We should not repeat ourselves.
> 
> The RNG device was available when registering the protocol. When it is no
> longer available in GetRng(), this is a device error and not an unsupported
> algorithm. Use EFI_DEVICE_ERROR returned by platform_get_rng_device() as
> return value of GetRng().
> 
> Heinrich Schuchardt (2):
>   efi_loader: in platform_get_rng_device() use EFI_PRINT()
>   efi_loader: consider type of platform_get_rng_device() return value

Please consider

Reviewed-by: Denis Mukhin <[email protected]> 

for the series.

> 
>  lib/efi_loader/efi_rng.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> -- 
> 2.53.0
>