Re: [PATCH 1/2] efi_loader: in platform_get_rng_device() use EFI_PRINT()

Ilias Apalodimas <[email protected]>
Newsgroups org.u-boot-project.lists.u-boot
Message-ID <CAC_iWj+HxQ4HK5_X1qKJT3NNqJbcPq6sQD=PLM8hkT-5k6vdbg@mail.gmail.com>
Hi Heinrich,


On Thu, 20 Aug 2026 at 16:08, Heinrich Schuchardt <
[email protected]> wrote:

> Use EFI_PRINT() instead of debug() to correctly indent the message.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
>  lib/efi_loader/efi_rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_rng.c b/lib/efi_loader/efi_rng.c
> index 7810b4e47ea..9c5a60ea963 100644
> --- a/lib/efi_loader/efi_rng.c
> +++ b/lib/efi_loader/efi_rng.c
> @@ -31,7 +31,7 @@ __weak efi_status_t platform_get_rng_device(struct
> udevice **dev)
>
>         ret = uclass_get_device(UCLASS_RNG, 0, &devp);
>         if (ret) {
> -               debug("Unable to get rng device\n");
> +               EFI_PRINT("Unable to get rng device\n");
>

All the users of that function print a similar message on failure. IMHO
just remove the print completely

Cheers
/Ilias

>                 return EFI_DEVICE_ERROR;
>         }
>
> --
> 2.53.0
>
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.