Re: [PATCH v2 01/14] video: mediatek: add display pipeline component helpers
David Lechner <[email protected]>
| Newsgroups | org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
On 8/26/26 8:09 AM, Julien Stephan wrote: > Most of the simple display pipeline components share the same probe > sequence: remap the register window and enable a bulk of clocks. Add nit: clocks aren't enable in probe. this could be worded more accurately. > the mtk_disp_comp helpers holding this boilerplate so each component > driver only has to provide its own component-specific programming. > > Signed-off-by: Julien Stephan <[email protected]> > --- > drivers/video/mediatek/mtk_disp_comp.c | 68 ++++++++++++++++++++++++++++++++++ > drivers/video/mediatek/mtk_disp_comp.h | 30 +++++++++++++++ > 2 files changed, 98 insertions(+) > > diff --git a/drivers/video/mediatek/mtk_disp_comp.c b/drivers/video/mediatek/mtk_disp_comp.c > new file mode 100644 > index 00000000000..3e76eae7f02 > --- /dev/null > +++ b/drivers/video/mediatek/mtk_disp_comp.c > @@ -0,0 +1,68 @@ > +// SPDX-License-Identifier: GPL-2.0 nit: GPL-2.0 is deprecated. prefer GPL-2.0-only or GPL-2.0-or-later applies to other patches as well