Re: [PATCH v2 00/14] mediatek: add HDMI pipeline support for MT8188 based boards

On 8/26/26 8:09 AM, Julien Stephan wrote:
> This series adds HDMI support for MT8188 based boards, such as the Genio
> 510 and Genio 700 EVKs, in order to display a boot logo over HDMI. It
> builds on top of the HDMI PHY driver [1], the DDC (I2C) driver [2], the
> clock series [3] and a clock fix [4] already sent earlier.
> 
> The drivers here, were inspired by the corresponding kernel driver, but
> were largely modified, mainly because U-Boot has no DRM framework and
> the goal is only to display a framebuffer. The HDMI driver locates each
> pipeline component through phandles in the hdmi node and programs them
> directly. The framebuffer and splash screen live in dedicated
> reserved-memory regions.

It would be helpful to add comments in the code where things were
intentionally modified to make it easier to know if differences were
intentional or might possibly be bugs.

> ---
> Changes in v2:
> - Add a common `get_unaligned_le24()` helper for reading 24-bit little-endian values, ported from kernel
> - Add a common `linux/hdmi.h` header with HDMI colorspace and colorimetry enums, based on the corresponding Linux header.
> - Refactor the HDMI driver to use the new common HDMI definitions and unaligned access helper.
> - Rename the mixer component to ETHDR and configure the ETHDR before the remaining display pipeline components.
> - Add the SMI LARB components and configure the VDOSYS1 routing directly from the HDMI driver.
> - Switch display component lookup from phandles to DT aliases and add proper error unwinding for component clocks, HDMI PHY power, and clock resources.
> - Refactor HDMI register access and InfoFrame handling.
> - Improve HDMI mode handling, YUV420 downsampling, TMDS scrambling, deep-color handling, and InfoFrame generation.
> - Move framebuffer/splash reserved-memory definitions to the Genio common U-Boot DTSI and add the corresponding HDMI override node for MT8390/Genio EVKs.
> - Drop the dedicated MT8188 VDOSYS1 pipeline component and its corresponding DTS node, to avoid having 2 nodes with same reg address.
> - Remove the unnecessary `dm_scan_fdt_dev` bind hook from the HDMI driver.

Looks like dm_scan_fdt_dev is still there. Perhaps necessary after all?

> - Link to v1: https://patch.msgid.link/20260728-add-genio-510-and-genio-700-hdmi-v1-0-ac54bd75f960@baylibre.com
>