Re: [PATCH v2 4/8] ARM: renesas: RZ/N1 QSPI controller features
Ralph Siemsen <[email protected]>
| Newsgroups | org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Aug 15, 2026 at 12:25:10AM +0200, Marek Vasut wrote: >On 8/14/26 8:38 PM, Ralph Siemsen wrote: >> >>diff --git a/arch/arm/mach-renesas/Kconfig b/arch/arm/mach-renesas/Kconfig >>index f86acc31039..4d16d541443 100644 >>--- a/arch/arm/mach-renesas/Kconfig >>+++ b/arch/arm/mach-renesas/Kconfig >>@@ -70,9 +70,13 @@ config RZN1 >> select DM >> select DM_ETH >> select DM_SERIAL >>+ select DM_SPI >> select PINCTRL >> select PINCONF >> select REGMAP >>+ select SPI > >Shouldn't this be in board config ? Not all RZN1 boards likely require SPI ? Any RZ/N1 board that makes use of the QSPI will want this. It could be done in the defconfig, but it is easy to miss, and not fun to debug (took many hours of printf() for me to find it) >>+ select SPI_MEM >>+ select SPI_DIRMAP >Shouldn't this be selected by the SPI NOR driver instead ? The same driver has other users, but they may not all want DIRMAP. I will move these settings under TARGET_SCHNEIDER_RZN1 so they are specific to this board. Ralph