RE: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology

Hirokazu Takahashi <[email protected]>
Newsgroups org.xenproject.lists.xen-devel
Message-ID <OS9P286MB7222B943BCE5602656CFF74882C62@OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM>
Hello,

> >>> --- a/xen/drivers/acpi/topology.c
> >>> +++ b/xen/drivers/acpi/topology.c
> >>
> >>
> >>>  int __init acpi_init_cpu_topology(void)
> >>>  {
> >>> +    acpi_status status;
> >>> +    struct acpi_table_header *table_header;
> >>> +    const struct acpi_table_pptt *pptt;
> >>> +    unsigned int num_sockets = 0;
> >>> +    unsigned int num_clusters = 0;
> >>> +    unsigned int num_cores = 0;
> >>> +    unsigned int *socket_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>> +    unsigned int *cluster_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>> +    unsigned int *core_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>
> >> These have to be xzmalloc_array().
> >
> > xzalloc_array()
> 
> xvzalloc_array(). And the others xvmalloc_array(). See the top of
> xen/xvmalloc.h.

Yes, you are right. I will fix it.
 
Hirokazu Takahashi.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.