Re: [PATCH] x86emul: drop dead conditional from decode
Andrew Cooper <[email protected]>
| Newsgroups | org.xenproject.lists.xen-devel |
|---|---|
| Message-ID | <[email protected]> |
On 30/06/2026 2:29 pm, Jan Beulich wrote:
> We know that opcode_table[0x0f] is 0, there's no need to check that. Up
> until ab082ffa87d5 ("x86emul: generate and make use of a canonical opcode
> representation") or maybe already c4e7a67e3a10 ("x86emul: drop
> SrcInvalid") this may have been justified, but it no longer is.
>
> This eliminates a Misra C:2012 rule 2.2 ("There shall be no dead code")
> violation.
>
> Signed-off-by: Jan Beulich <[email protected]>
Acked-by: Andrew Cooper <[email protected]>