Re: [PATCH v7 5/7] xen/serial: drop stale SERIAL_NEVER_DROP_CHARS

On 13.07.2026 20:16, [email protected] wrote:
> From: Denis Mukhin <[email protected]> 
> 
> Signed-off-by: Denis Mukhin <[email protected]>

It would have helped if the origin of it being stale was identified right
away. Looks like 275485700163 ("Bring back console_start_log_everything()
as a milder alternative to") dropped the sole use only a few weeks after
its introduction.

Acked-by: Jan Beulich <[email protected]>

> --- a/xen/drivers/char/serial.c
> +++ b/xen/drivers/char/serial.c
> @@ -15,9 +15,6 @@
>  
>  #include <asm/processor.h>
>  
> -/* Never drop characters, even if the async transmit buffer fills. */
> -/* #define SERIAL_NEVER_DROP_CHARS 1 */
> -
>  unsigned int __ro_after_init serial_txbufsz = CONFIG_SERIAL_TX_BUFSIZE;
>  size_param("serial_tx_buffer", serial_txbufsz);
>