Re: [PATCH 7/8] hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn

Christian Schoenebeck <[email protected]>
Newsgroups org.xenproject.lists.xen-devel,org.nongnu.qemu-devel
Message-ID <6287083.lOV4Wx5bFT@weasel>
On Tuesday, 21 July 2026 10:25:34 CEST Philippe Mathieu-Daudé wrote:
> On 21/7/26 10:06, Marc-André Lureau wrote:
> > Hi
> > 
> > On Tue, Jul 21, 2026 at 11:58 AM Marc-André Lureau
> > 
> > <[email protected]> wrote:
[...]
> >> most of them are "return-type co_annotation fn(..)"
> >> we even have scripts/block-coroutine-wrapper.py that relies and
> >> produce this order..
> >> a bit late to change the style imho...
> >> 
> >> At least, let's not make this a requirement for this series, please
> 
> Not a requirement on my side, but if we had to pick a style,
> I'd vote for "attribute before return type".

Yep, because that's a) the most compiler-friendly option (all compilers allow 
it, including MSC) and b) it's the most diff-noise friendly solution (can be 
prepended on its own line without touching any of the existing line(s) at 
all).

/Christian
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.