RE: [EXTERNAL] [XEN PATCH v1 2/2] docs/fusa: add generic timer arch spec with ASCII diagrams
"Weber (US), Matthew L" <[email protected]>
| Newsgroups | org.xenproject.lists.xen-devel |
|---|---|
| Message-ID | <SA1P110MB2076559C830AB1A9267A5577F3C2A@SA1P110MB2076.NAMP110.PROD.OUTLOOK.COM> |
All, > On 21.07.2026 14:47, Ayan Kumar Halder wrote: > +Generic timer usage during VM creeation > +--------------------------------------- Typo: "creeation" -> "creation" > +- CNTVCT_EL0 - virtual count value > +- CNTV_CTL_EL0 - control register > +- CNTV_CVAL_EL0 - compare value register > +- CNTV_TVAL_EL0 - compare value register CNTV_TVAL_EL0 should be "timer value register", not "compare value register". CVAL is the comparator, TVAL is the countdown/timer-value alias. (Same naming as CNTP_TVAL_EL0 earlier in the same section.) > +The interrupt behave in a level-sensitive manner, meaning the timer will Grammar: "The interrupt behaves" (singular). > + * - physical non secure timer > + - 30 Nit: ARM uses "Non-secure" (hyphenated, capitalized). Suggest "physical Non-secure timer" for consistency with the spec terminology. > +| [1] Arm Architecture Reference Manual for A-profile architecture, Chapter 11 > +| [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml These would render better as proper RST footnotes: .. [1] Arm Architecture Reference Manual for A-profile architecture, Chapter 11 .. [2] https://git.kernel.org/... That way Sphinx cross-references and numbered citations work correctly in the built HTML. Overall the spec is well structured, thanks Ayan! Reviewed-by: Weber (US), Matthew L <[email protected]>