RE: [PATCH v7 1/5] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration

Hi Jan,

Thank you for the reviewing.

> > +    for ( cpu = 0; cpu < nr_cpu_ids; cpu++ )
> > +    {
> > +        if ( !zalloc_cpumask_var(&cpu_topology[cpu].thread_sibling)
> > +             || !zalloc_cpumask_var(&cpu_topology[cpu].core_sibling)
> > +             || !zalloc_cpumask_var(&cpu_topology[cpu].cluster_sibling) )
> 
> In v6 the || here were correctly placed. Why did they move?

I saw other code using leading || and tried to match that, but I'll revert it back.

> > --- a/xen/common/cpu.c
> > +++ b/xen/common/cpu.c
> > @@ -46,6 +46,10 @@ const unsigned long
> cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)] = {
> >  #undef MASK_DECLARE_2
> >  #undef MASK_DECLARE_1
> >
> > +#ifdef CONFIG_GENERIC_CPU_TOPOLOGY
> > +struct cpu_topology *__ro_after_init cpu_topology;
> > +#endif /* CONFIG_GENERIC_CPU_TOPOLOGY */
> 
> Looks like you also need to include xen/cpu-topology.h here. I can't see
> it being included implicitly.

Okay,
 
> > --- a/xen/drivers/acpi/Kconfig
> > +++ b/xen/drivers/acpi/Kconfig
> > @@ -2,6 +2,9 @@
> >  config ACPI
> >  	bool
> >
> > +config ACPI_CPU_TOPOLOGY
> > +	bool
> > +
> >  config ACPI_LEGACY_TABLES_LOOKUP
> >  	bool
> >
> 
> Did you forget to undo this change?

Oops, I will remove it.

> With all three adjustments:
> Reviewed-by: Jan Beulich <[email protected]> # common, acpi

Thank you,
Hirokazu Takahashi.