Re: [PATCH v3 08/23] xen/arm: vsmmuv3: Add support for registers emulation

>   struct virt_smmu {
>       struct      domain *d;
>       struct      list_head viommu_list;
> +    uint8_t     sid_split;
> +    uint32_t    features;
> +    uint32_t    cr[3];
> +    uint32_t    cr0ack;
> +    uint32_t    gerror;
> +    uint32_t    gerrorn;
> +    uint32_t    strtab_base_cfg;
> +    uint64_t    strtab_base;
> +    uint32_t    irq_ctrl;
> +    uint64_t    gerror_irq_cfg0;
> +    uint64_t    evtq_irq_cfg0;
> +    struct      arm_vsmmu_queue evtq, cmdq;
>   };
>   

Hi Rahul/Milan,


Any reason why the GBPA register emulation is not added?

When "arm_smmu_device_reset" would be called by the guest kernel, it 
would fail.


Thanks,

Abhash