Re: [PATCH] x86/vrtc: Use a real type for rtc_ioport_write()

On 28.07.2026 14:31, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <[email protected]>

Reviewed-by: Jan Beulich <[email protected]>

> --- a/xen/arch/x86/hvm/rtc.c
> +++ b/xen/arch/x86/hvm/rtc.c
> @@ -469,9 +469,8 @@ static void cf_check rtc_alarm_cb(void *opaque)
>      spin_unlock(&s->lock);
>  }
>  
> -static int rtc_ioport_write(void *opaque, uint32_t addr, uint32_t data)
> +static int rtc_ioport_write(RTCState *s, uint32_t addr, uint32_t data)
>  {
> -    RTCState *s = opaque;
>      struct domain *d = vrtc_domain(s);
>      uint32_t orig;

It's entirely unclear why it was ever done like this. Even in 3.2 it could
already have been done the type-correct way.

Jan