Re: [PATCH] acpi: reboot: log reset parameters

On 31.07.2026 06:42, [email protected] wrote:
> On Thu, Jul 30, 2026 at 08:26:38AM +0200, Jan Beulich wrote:
>> On 30.07.2026 02:18, [email protected] wrote:
>>> --- a/xen/drivers/acpi/reboot.c
>>> +++ b/xen/drivers/acpi/reboot.c
>>> @@ -6,6 +6,7 @@ void acpi_reboot(void)
>>>  {
>>>  	struct acpi_generic_address *rr;
>>>  	u8 reset_value;
>>> +	pci_sbdf_t sbdf;
>>>  
>>>  	rr = &acpi_gbl_FADT.reset_register;
>>>  
>>> @@ -21,17 +22,24 @@ void acpi_reboot(void)
>>>  	 * on a device on bus 0. */
>>>  	switch (rr->space_id) {
>>>  	case ACPI_ADR_SPACE_PCI_CONFIG:
>>> -		printk("Resetting with ACPI PCI RESET_REG.\n");
>>> +		sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16);
>>> +		printk("Resetting with ACPI PCI %pp RESET_REG at 0x%"PRIx64" (0x%x)\n",
>>> +			&sbdf, rr->address & 0xffu, reset_value);
>>
>> As indicated on other occasions - %#x and alike please in favor of 0x%x.
>>
>> I also see no reason for the 'u' suffix on the literal number. Plus if one
>> was wanted, it would want to be 'U', to match the Misra-demanded 'L'.
>>
>> Also - nit: Indentation.
> 
> Thanks for taking a look!
> 
> This file uses tabs - I can convert to spaces, but in separate patch.

That wasn't the point of my remark though. Merely switching to all-blanks
indentation would be wrong. Converting altogether to Xen style would be
an option. My remark was about you not using the necessary mix of tabs
and blanks when the wrapped part of a statement want to align with the
respective part on the earlier line. I.e. here two tabs followed by 7
blanks.

Jan