Re: [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y

On 02.08.2026 17:05, Daniel P. Smith wrote:
> On 7/28/26 9:17 AM, Jan Beulich wrote:
>> They're unreachable / dead otherwise.
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>> ---
>> Strictly speaking .hvm_param_altp2mhvm() is dependent upon X86=y as well
>> (but oddly not dependent upon ALTP2M=y).
> 
> At a minimum, would it be worth at least adding a comment about the 
> dependency? Note, this is just a question/suggestion.

Just a comment would be too little imo. One way or another we want to sort
this properly. With the first question being - why a separate hook, and
hence why the double checking for HVM_PARAM_ALTP2M? With further data
passed into the hook, the Flask case can easily be dealt with using just a
single hook. The XSM_TARGET vs XSM_PRIV makes this a little less nice for
dummy.

Jan