Re: [PATCH 4/4] x86: add new pte_get_and_clear hypercall

On 27.07.2026 17:06, Kevin Lampis wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3993,6 +3993,7 @@ static long __do_mmu_update(
>      unsigned int count,
>      XEN_GUEST_HANDLE_PARAM(uint) pdone,
>      unsigned int foreigndom,
> +    unsigned int op,
>      bool write_back_old)
>  {

Likely irrelevant anyway when this becomes a new sub-op instead of a new
top-level hypercall, but: "op" is redundant with "write_back_old". Such
redundancy wants avoiding.

Jan