Re: [MINI-OS PATCH] build: don't add -lm -lpci -lz to APP_LDLIBS

Juergen Gross, le jeu. 13 août 2026 16:35:36 +0200, a ecrit:
> libm, libpci and libz are not always needed, so don't add them to
> APP_LDLIBS just because libc is selected.
> 
> In case they will be needed by someone, they should be added via a
> dedicated CONFIG option.
> 
> Note that none of the currently supported Xen stubdoms is using them.
> 
> Signed-off-by: Juergen Gross <[email protected]>

Agreed,

Reviewed-by: Samuel Thibault <[email protected]>

> ---
>  Makefile | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index a64913a..7510d5d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -164,9 +164,6 @@ ifeq ($(CONFIG_LIBXENMANAGE),y)
>  APP_LDLIBS += -L$(MANAGE_PATH) -whole-archive -lxenmanage -no-whole-archive
>  LIBS += $(MANAGE_PATH)/libxenmanage.a
>  endif
> -APP_LDLIBS += -lpci
> -APP_LDLIBS += -lz
> -APP_LDLIBS += -lm
>  LDLIBS += -lc
>  endif
>  
> -- 
> 2.55.0
>