Re: [PATCH 1/3] x86/emul: Adjust comments in x86-types.h

On 14.08.2026 20:58, Andrew Cooper wrote:
> x86_segment enumerates segments, not segment registers.  Adjust the comment to
> make this clearer.
> 
> Fix a stray tab with the closing #endif.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <[email protected]>

Acked-by: Jan Beulich <[email protected]>

I wonder though if we wouldn't better ...

> --- a/xen/arch/x86/include/asm/x86-types.h
> +++ b/xen/arch/x86/include/asm/x86-types.h
> @@ -16,9 +16,10 @@
>  #endif
>  
>  /*
> - * Comprehensive enumeration of x86 segment registers.  Various bits of code
> - * rely on this order (general purpose before system, tr at the beginning of
> - * system).
> + * x86 Segments.

... insert "(kind of)" here: "sys" and "none" aren't really "segments", and
iirc we said we may need to gain one more such pseudo-segment here to deal
with WR{,U}SS.

Jan