Re: [RFC PATCH v7 06/14] vtd: Remove MAP_ERROR_RECOVERY code path in domain_context_mapping_one

Jan Beulich <[email protected]>
Newsgroups org.xenproject.lists.xen-devel
Message-ID <[email protected]>
On 20.11.2025 12:09, Teddy Astie wrote:
> This logic is basically never called as the only possible failures are
> - no memory to allocate the pagetable (if it isn't already allocated)
>   this is fixed in this patch serie by ensuring that the pagetable is allocated
>   when entering this function
> - EILSEQ when there is a race condtion with hardware, which should not happen under
>   normal circonstances
> 
> Remove this logic to simplify the error management of the function.

But this code was added for a reason, yet you (again) don't make clear why
the change you make is correct. Putting in place something else _later_ in
the series isn't really an option. Things need to work at every patch
boundary.

Considering that (long ago) you indicated anyway that you'd work towards
better splitting up some of the large patches here, I think I'll stop here,
waiting for a re-submission.

Jan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.