[PATCH v4 0/6] Fix ARM domcreate
Julian Vetter <[email protected]>
| Newsgroups | org.xenproject.lists.xen-devel |
|---|---|
| Message-ID | <1787229492.8631fc262581453bbf619ec5b2062170.1a01f2dd31e000c4f3@vates.tech> |
Hello Michal, Andrew and Jan, thank you for your reviews! I have addressed your feedback, i.e., GICv2 compatibility-mode reporting, ASSERT_UNREACHABLE() for the invalid case, and the comment typo. I also changed patch 4 to no longer bump XEN_DOMCTL_INTERFACE_VERSION for the XEN_DOMCTL_CONFIG_GIC_NATIVE removal and I have also updated the timer frequency reporting. Signed-off-by: Julian Vetter <[email protected]> --- Changes in v4: - Patch 1: Added Reviewed-by - Patch 2: Also report GICv2 support when a GICv3 host has the vGICv2 compatibility mode enabled - Patch 3: Fix the missing closing bracket in arch_capabilities_arm_has() - Patch 4: Don't bump XEN_DOMCTL_INTERFACE_VERSION for the removal of XEN_DOMCTL_CONFIG_GIC_NATIVE and report the requested GIC version in the "Unsupported GIC version" print - Patch 5: Always populate the reported timer frequency, including in the CNTFRQ_EL0 path, so ACPI guests get a real value instead of 0 (previously only reported when booting via DT) - Patch 6: Shorten the arch_sanitise_domain_config() comment --- Andrew Cooper (1): ARM/sysctl: Expose the supported guest GIC modes in physinfo Julian Vetter (5): xen/arm: report proper GIC version via XEN_DOMCTL_getdomaininfo tools/arm: choose GIC version explicitly instead of relying on GIC_NATIVE xen/arm: remove XEN_DOMCTL_CONFIG_GIC_NATIVE from the ABI xen/arm: report clock_frequency via sysctl physinfo, not createdomain xen: make config argument const CHANGELOG.md | 4 ++ .../include/xen-tools/arm-arch-capabilities.h | 17 +++++++++ tools/libs/light/libxl.c | 1 + tools/libs/light/libxl_arm.c | 30 +++++++++++++-- tools/libs/light/libxl_types.idl | 1 + tools/ocaml/libs/xc/xenctrl.ml | 1 - tools/ocaml/libs/xc/xenctrl.mli | 1 - tools/python/xen/lowlevel/xc/xc.c | 20 +++++++++- xen/arch/arm/dom0less-build.c | 3 +- xen/arch/arm/domain.c | 28 +++++--------- xen/arch/arm/domain_build.c | 3 +- xen/arch/arm/domctl.c | 2 + xen/arch/arm/firmware/sci.c | 2 +- xen/arch/arm/firmware/scmi-smc.c | 2 +- xen/arch/arm/gic.c | 16 ++++++++ xen/arch/arm/include/asm/firmware/sci.h | 6 +-- xen/arch/arm/include/asm/gic.h | 6 +++ xen/arch/arm/include/asm/time.h | 6 +-- xen/arch/arm/include/asm/vgic.h | 6 +++ xen/arch/arm/include/asm/vtimer.h | 3 +- xen/arch/arm/sysctl.c | 37 +++++++++++++++++++ xen/arch/arm/time.c | 7 ++-- xen/arch/arm/vgic-v2.c | 5 +++ xen/arch/arm/vtimer.c | 4 +- xen/arch/ppc/stubs.c | 2 +- xen/arch/riscv/domain.c | 2 +- xen/arch/x86/domain.c | 16 ++++---- xen/include/public/arch-arm.h | 18 +-------- xen/include/public/sysctl.h | 14 ++++++- xen/include/xen/sched.h | 5 +-- 30 files changed, 195 insertions(+), 73 deletions(-) -- 2.53.0 -- | Vates XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech