Re: [docs] [PATCH v2] dev-manual: add second way to assign "PV" for external SCM

Hi,

On Fri Jun 19, 2026 at 5:56 PM CEST, Robert P. J. Day wrote:
> On Fri, 19 Jun 2026, Quentin Schulz wrote:
>
>> Hi Robert,
>>
>> On 6/16/26 10:32 PM, Robert P. J. Day via lists.yoctoproject.org wrote:
>> >
>> > In addition to hard-coding a PV value in the context of an external
>> > SCM, show also just appending the string "+git" to the value already
>> > calculated for PV.
>> >
>> > Signed-off-by: Robert P. J. Day <[email protected]>
>> >
>> > ---
>> >
>> > diff --git a/documentation/dev-manual/external-scm.rst
>> > b/documentation/dev-manual/external-scm.rst
>> > index 3ca9079b3..cac23ac1e 100644
>> > --- a/documentation/dev-manual/external-scm.rst
>> > +++ b/documentation/dev-manual/external-scm.rst
>> > @@ -13,9 +13,13 @@ Subversion (SVN) and Git.
>> >
>> >   To enable this behavior, the :term:`PV` of
>> >   the recipe needs to include a ``+`` sign in its assignment.
>> > -Here is an example::
>> > +Here are a couple examples of how this can be done --- the first
>> > +hard-coding the value for ``PV``, the second simply appending
>> > +the string "+git" to the value of ``PV`` already extracted from
>> > +the recipe file name::
>> >
>> >      PV = "1.2.3+git"
>> > +   PV .= "+git"
>> >
>>
>> This is confusing. Do you mean that
>>
>> PV = "1.2.3+git+git"
>>
>> will end up being
>>
>> PV = "1.2.3-gbebedada+git"
>> ?
>
>   no, the text mentions that those are a couple possibilities for
> setting that variable -- you'd use one or the other, not both.

I think I see what Quentin is saying, that you can misinterpret this and add the
two lines to your recipe, while only one of the two is needed.

I think this would clearer if you split the two examples and precede them with
what they stand for.

Antonin