Re: [meta-ti][master][PATCH v3] meta-ti-bsp: Add udev rules for MCAN to meta-ti

On Fri, Jan 30, 2026 at 04:36:22PM +0530, Anurag Dutta wrote:
> Add MCAN udev rules to meta-ti so that MCAN tests run
> successfully.

Thanks, this is getting close, but I have a couple of comments (besides the 
wrong list), see below.


> Signed-off-by: Anurag Dutta <[email protected]>
> ---
> Tested on j721s2 (poky) : https://gist.github.com/anuragdutta731/67c24da1616e74efa2b117a3bd88ada6
> 
> Link to v1 : https://lore.kernel.org/all/[email protected]/
> changelog v2:
> 1. moved all the rules from meta-arago-distro to meta-arago-test
> 2. removed udev* from meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> 
> Link to v2: https://lore.kernel.org/all/[email protected]/
> changelog v3:
> 1.Added the udev rules to meta-ti
> 
>  meta-ti-bsp/conf/machine/include/k3.inc       |  2 +-
>  .../udev/udev-ticonf/37-can-am62.rules        |  4 ++++
>  .../udev/udev-ticonf/37-can-dra7.rules        |  2 ++
>  .../udev/udev-ticonf/37-can-j7.rules          | 20 +++++++++++++++++
>  .../udev/udev-ticonf/37-can-ti33x.rules       |  2 ++
>  .../recipes-core/udev/udev-ticonf_1.bb        | 22 +++++++++++++++++++
>  6 files changed, 51 insertions(+), 1 deletion(-)
>  create mode 100644 meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-am62.rules
>  create mode 100644 meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-dra7.rules
>  create mode 100644 meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-j7.rules
>  create mode 100644 meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-ti33x.rules
>  create mode 100644 meta-ti-bsp/recipes-core/udev/udev-ticonf_1.bb
> 
> diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc
> index 698b46d7..68129df9 100644
> --- a/meta-ti-bsp/conf/machine/include/k3.inc
> +++ b/meta-ti-bsp/conf/machine/include/k3.inc
> @@ -39,7 +39,7 @@ UBI_VOLNAME = "rootfs"
>  
>  # List common SoC features, may need to add touchscreen for specific machines
>  MACHINE_FEATURES = "apm usbgadget usbhost vfat ext2 alsa pci optee-ftpm"
> -MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "ti-pka-fw"
> +MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "ti-pka-fw udev-ticonf"

You are only adding this to k3.inc, but the recipe installs rules for 4 SoC 
families - am62, j7, dra7 and ti33x. The last 2 are not part of k3 and the 
same change needs to be added to their corresponding SoC family .inc files.


>  IMAGE_FSTYPES += "tar.xz wic.xz wic.bmap"
>  
> diff --git a/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-am62.rules b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-am62.rules
> new file mode 100644
> index 00000000..59dc8075
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-am62.rules
> @@ -0,0 +1,4 @@
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="4e08000.can", NAME="mcu_mcan0"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="4e18000.can", NAME="mcu_mcan1"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="20701000.can", NAME="main_mcan0"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="20711000.can", NAME="main_mcan1"
> diff --git a/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-dra7.rules b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-dra7.rules
> new file mode 100644
> index 00000000..3b14150d
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-dra7.rules
> @@ -0,0 +1,2 @@
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="4ae3c000.can", NAME="main_dcan1"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="48480000.can", NAME="main_dcan2"
> diff --git a/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-j7.rules b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-j7.rules
> new file mode 100644
> index 00000000..f2804ecd
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-j7.rules
> @@ -0,0 +1,20 @@
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="40528000.can", NAME="mcu_mcan0"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="40568000.can", NAME="mcu_mcan1"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2701000.can", NAME="main_mcan0"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2711000.can", NAME="main_mcan1"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2721000.can", NAME="main_mcan2"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2731000.can", NAME="main_mcan3"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2741000.can", NAME="main_mcan4"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2751000.can", NAME="main_mcan5"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2761000.can", NAME="main_mcan6"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2771000.can", NAME="main_mcan7"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2781000.can", NAME="main_mcan8"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2791000.can", NAME="main_mcan9"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="27a1000.can", NAME="main_mcan10"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="27b1000.can", NAME="main_mcan11"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="27c1000.can", NAME="main_mcan12"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="27d1000.can", NAME="main_mcan13"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2681000.can", NAME="main_mcan14"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="2691000.can", NAME="main_mcan15"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="26a1000.can", NAME="main_mcan16"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="26b1000.can", NAME="main_mcan17"
> diff --git a/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-ti33x.rules b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-ti33x.rules
> new file mode 100644
> index 00000000..62d650fe
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-core/udev/udev-ticonf/37-can-ti33x.rules
> @@ -0,0 +1,2 @@
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="481cc000.can", NAME="main_dcan0"
> +SUBSYSTEM=="net", ACTION=="add", KERNELS=="481d0000.can", NAME="main_dcan1"
> diff --git a/meta-ti-bsp/recipes-core/udev/udev-ticonf_1.bb b/meta-ti-bsp/recipes-core/udev/udev-ticonf_1.bb
> new file mode 100644
> index 00000000..1ef487c2
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-core/udev/udev-ticonf_1.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "Udev rules for assorted TI SoCs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit bin_package
> +
> +SRC_URI = " \
> +    file://37-can-j7.rules \
> +    file://37-can-am62.rules \
> +    file://37-can-dra7.rules \
> +    file://37-can-ti33x.rules \
> +"
> +
> +S = "${WORKDIR}"

This is incorrect for master, need to use UNPACKDIR.


> +do_install() {
> +    install -d ${D}${libdir}/udev/rules.d
> +    install -m 0644 ${WORKDIR}/37-can-j7.rules ${D}${libdir}/udev/rules.d/
> +    install -m 0644 ${WORKDIR}/37-can-am62.rules ${D}${libdir}/udev/rules.d/
> +    install -m 0644 ${WORKDIR}/37-can-dra7.rules ${D}${libdir}/udev/rules.d/
> +    install -m 0644 ${WORKDIR}/37-can-ti33x.rules ${D}${libdir}/udev/rules.d/
> +}
> -- 
> 2.34.1