Re: [meta-arago][master][PATCH v2] linuxptp: Add support for HSR in Linux ptp
MD Danish Anwar <[email protected]>
| Newsgroups | org.yoctoproject.lists.meta-arago |
|---|---|
| Message-ID | <[email protected]> |
Hi Denys, On 03/03/26 2:10 am, Denys Dmytriyenko wrote: > On Mon, Mar 02, 2026 at 04:05:15PM +0530, MD Danish Anwar via lists.yoctoproject.org wrote: >> Signed-off-by: MD Danish Anwar <[email protected]> >> --- >> These patches have been posted to upstream linuxptp mailing list. >> https://lists.nwtime.org/sympa/arc/linuxptp-devel/2025-11/msg00013.html >> They are currently under review. >> >> v1 -> v2: >> Added Upstream Status in each patch. >> >> .../linuxptp/linuxptp-arago.inc | 19 + >> ...age-of-non-PTP-packets-during-socket.patch | 81 +++ >> ...d-dataset_comparison-type-IEC62439-3.patch | 217 +++++++ >> .../0003-Add-PASSIVE_SLAVE-state.patch | 275 +++++++++ >> .../0004-rtnl-Add-rtnl_get_hsr_devices.patch | 120 ++++ >> .../0005-port-Add-paired_port-option.patch | 175 ++++++ >> ...-a-state-engine-for-redundant-master.patch | 519 ++++++++++++++++ >> ...ouble-attached-clock-hybrid-clock-HC.patch | 444 ++++++++++++++ >> ...orward-packets-both-ways-in-DAC-mode.patch | 37 ++ >> ...guard-in-case-PASSIVE_SLAVE-attempts.patch | 37 ++ >> ...w-to-forward-packets-in-LISTEN-state.patch | 61 ++ >> .../linuxptp/0011-raw-Add-HSR-handling.patch | 567 ++++++++++++++++++ >> ...Add-sample-configs-for-the-HSR-setup.patch | 96 +++ >> ...2p_dst_mac-to-avoid-IEEE-802.1-reser.patch | 47 ++ >> .../linuxptp/linuxptp_%.bbappend | 4 + >> 15 files changed, 2699 insertions(+) >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp-arago.inc >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0001-raw-Prevent-leakage-of-non-PTP-packets-during-socket.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0002-port-Add-dataset_comparison-type-IEC62439-3.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0003-Add-PASSIVE_SLAVE-state.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0004-rtnl-Add-rtnl_get_hsr_devices.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0005-port-Add-paired_port-option.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0006-fsm-Add-a-state-engine-for-redundant-master.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0007-p2p_hc-Add-a-double-attached-clock-hybrid-clock-HC.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0008-tc-Allow-to-forward-packets-both-ways-in-DAC-mode.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0009-port-Add-a-safe-guard-in-case-PASSIVE_SLAVE-attempts.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0010-tc-Allow-to-forward-packets-in-LISTEN-state.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0011-raw-Add-HSR-handling.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0012-configs-Add-sample-configs-for-the-HSR-setup.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0013-configs-Change-p2p_dst_mac-to-avoid-IEEE-802.1-reser.patch >> create mode 100644 meta-arago-distro/recipes-connectivity/linuxptp/linuxptp_%.bbappend >> >> diff --git a/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp-arago.inc b/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp-arago.inc >> new file mode 100644 >> index 00000000..17819cf3 >> --- /dev/null >> +++ b/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp-arago.inc >> @@ -0,0 +1,19 @@ >> +PR:append = ".arago6" > > This is the first submission, why is it .arago6? > This is my first time submitting patch to meta-arago. I am not aware 6 mean in `.arago6`. I just looked at the code for iproute2 [1] (as there also custom patches are being applied) and followed the same syntax for linuxptp. Can you please let me know what should I use here? > >> + >> +FILESEXTRAPATHS:prepend := "${THISDIR}/linuxptp:" >> + >> +SRC_URI:append = " \ > > There's absolutely no reason to suee :append here vs. a simple += > > >> + file://0001-raw-Prevent-leakage-of-non-PTP-packets-during-socket.patch \ >> + file://0002-port-Add-dataset_comparison-type-IEC62439-3.patch \ >> + file://0003-Add-PASSIVE_SLAVE-state.patch \ >> + file://0004-rtnl-Add-rtnl_get_hsr_devices.patch \ >> + file://0005-port-Add-paired_port-option.patch \ >> + file://0006-fsm-Add-a-state-engine-for-redundant-master.patch \ >> + file://0007-p2p_hc-Add-a-double-attached-clock-hybrid-clock-HC.patch \ >> + file://0008-tc-Allow-to-forward-packets-both-ways-in-DAC-mode.patch \ >> + file://0009-port-Add-a-safe-guard-in-case-PASSIVE_SLAVE-attempts.patch \ >> + file://0010-tc-Allow-to-forward-packets-in-LISTEN-state.patch \ >> + file://0011-raw-Add-HSR-handling.patch \ >> + file://0012-configs-Add-sample-configs-for-the-HSR-setup.patch \ >> + file://0013-configs-Change-p2p_dst_mac-to-avoid-IEEE-802.1-reser.patch \ >> +" >> diff --git a/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0001-raw-Prevent-leakage-of-non-PTP-packets-during-socket.patch b/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0001-raw-Prevent-leakage-of-non-PTP-packets-during-socket.patch >> new file mode 100644 >> index 00000000..ea0f968c >> --- /dev/null >> +++ b/meta-arago-distro/recipes-connectivity/linuxptp/linuxptp/0001-raw-Prevent-leakage-of-non-PTP-packets-during-socket.patch >> @@ -0,0 +1,81 @@ >> +From 5afe386619bfcded393fd5a9ea5d7c9bbcf05823 Mon Sep 17 00:00:00 2001 >> +From: Cliff Spradlin <[email protected]> >> +Date: Thu, 2 Oct 2025 18:37:54 -0700 >> +Subject: [PATCH 01/13] raw: Prevent leakage of non-PTP packets during socket >> + init >> + >> +There were two problems with the socket configuration sequencing: >> + >> +1) Calling socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL)) causes all >> +ethernet frames from -all- interfaces to be queued to the socket, >> +until bind() is later called. >> + >> +2) The BPF filter is installed -after- bind() is called, so ethernet >> +frames that should be rejected could be queued before the BPF filter >> +is installed. >> + >> +This patch reorders the raw socket initialization so that all >> +configuration happens before bind() is called. >> + >> +Signed-off-by: Cliff Spradlin <[email protected]> >> +Signed-off-by: Sebastian Andrzej Siewior <[email protected]> >> +Signed-off-by: MD Danish Anwar <[email protected]> >> +--- >> +Upstream-Status: >> +Submitted >> + Submitted to upstream, waiting approval >> + https://lists.nwtime.org/sympa/arc/linuxptp-devel/2025-11/msg00007.html > > While there's no specific requirement to have this before the --- line, it > still must be in a single line. Same comment to all patches. > Sure. I will address this in v3. > >> + >> + raw.c | 22 +++++++++++----------- [1] https://git.ti.com/cgit/arago-project/meta-arago/tree/meta-arago-distro/recipes-connectivity/iproute2/iproute2_%25.bbappend?h=scarthgap-next&id=ee4d898485d9474abacf8ec092e61fdfc0efa348 -- Thanks and Regards, Danish