Re: [meta-arago][master][PATCH 1/4] arm-compute-library: upgrade 24.12 -> 52.07
Pratham Deshmukh <[email protected]>
| Newsgroups | org.yoctoproject.lists.meta-arago |
|---|---|
| Message-ID | <[email protected]> |
On 04/03/26 10:14 pm, Andrew Davis wrote: > On 3/4/26 6:32 AM, Pratham Deshmukh wrote: >> We are migrating ARM Compute Library from v24.12 to the >> latest version v52.07 >> >> Removed Patches: >> • 0001-fix-Fix-indention-in-cmake-generator-script.patch >> - Upstream Link: >> https://github.com/ARM-software/ComputeLibrary/commit/e0c42ef651709fd284da3bedd2c98d420bd6fd1a >> • 0005-Add-CMake-options-for-SVE-SVE2-and-BF16-support.patch >> - No need for this patch for v52.07 ACL. >> >> Rebased Patches: >> • Following patches are updated with new commits >> - 0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch >> - 0003-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE-.patch >> - 0004-Add-source-files-at-library-definition-time.patch >> - 0006-Allow-SVE-and-SVE2-support-to-be-disabled-in-CMake.patch >> - 0007-Allow-ARMv7-builds-using-CMake.patch >> - 0008-Fix-undefined-symbol-error-when-building-TensorInfo.patch >> >> Signed-off-by: Pratham Deshmukh <[email protected]> >> --- >> ...NABLE_NEON-in-code-for-checking-NEO.patch} | 72 ++--- >> ...-indention-in-cmake-generator-script.patch | 130 --------- >> ...ENABLE_SVE-in-code-for-checking-SVE.patch} | 117 ++++----- >> ...ce-files-at-library-definition-time.patch} | 246 ++++++++++-------- >> .../0004-Allow-ARMv7-builds-using-CMake.patch | 174 +++++++++++++ >> ...ptions-for-SVE-SVE2-and-BF16-support.patch | 112 -------- >> ...mbol-error-when-building-TensorInfo.patch} | 24 +- >> ...SVE2-support-to-be-disabled-in-CMake.patch | 91 ------- >> .../0006-Remove-TARGET-dependency.patch | 58 +++++ >> .../0007-Allow-ARMv7-builds-using-CMake.patch | 86 ------ >> ...rate-generic-library-name-instead-of.patch | 33 +++ >> .../0008-Add-FP16-source-path.patch | 28 ++ >> ..._24.12.bb => arm-compute-library_52.07.bb} | 56 ++-- >> 13 files changed, 551 insertions(+), 676 deletions(-) >> rename >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch >> => 0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch} >> (58%) >> delete mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0001-fix-Fix-indention-in-cmake-generator-script.patch >> rename >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0003-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE-.patch >> => 0002-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE.patch} (67%) >> rename >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0004-Add-source-files-at-library-definition-time.patch >> => 0003-Add-source-files-at-library-definition-time.patch} (24%) >> create mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0004-Allow-ARMv7-builds-using-CMake.patch >> delete mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0005-Add-CMake-options-for-SVE-SVE2-and-BF16-support.patch >> rename >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0008-Fix-undefined-symbol-error-when-building-TensorInfo.patch >> => 0005-Fix-undefined-symbol-error-when-building-TensorInfo.patch} (68%) >> delete mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0006-Allow-SVE-and-SVE2-support-to-be-disabled-in-CMake.patch >> create mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0006-Remove-TARGET-dependency.patch >> delete mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0007-Allow-ARMv7-builds-using-CMake.patch >> create mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0007-cmake-Generate-generic-library-name-instead-of.patch >> create mode 100644 >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0008-Add-FP16-source-path.patch >> rename >> meta-arago-extras/recipes-devtools/arm-compute-library/{arm-compute-library_24.12.bb >> => arm-compute-library_52.07.bb} (58%) >> > > Is the version 52.07? looks like they call it 52.7.0 > > [...] > Yes its 52.7.0. Will change this. >> diff --git >> a/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_24.12.bb >> b/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_52.07.bb >> >> similarity index 58% >> rename from >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_24.12.bb >> rename to >> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_52.07.bb >> index 42e2f343..42040445 100644 >> --- >> a/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_24.12.bb >> +++ >> b/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library_52.07.bb >> @@ -1,20 +1,20 @@ >> SUMMARY = "The ARM Computer Vision and Machine Learning library" >> DESCRIPTION = "The ARM Computer Vision and Machine Learning library >> is a set of functions optimised for both ARM CPUs and GPUs." >> LICENSE = "MIT" >> -LIC_FILES_CHKSUM = >> "file://LICENSES/MIT.txt;md5=35f8944fae972976691f3483b0ac9dba" >> +LIC_FILES_CHKSUM = >> "file://LICENSES/MIT.txt;md5=3912d958d00bac4a6b550f75d7c806bb" >> SRC_URI = " \ >> - >> git://github.com/ARM-software/ComputeLibrary.git;branch=archived-releases;protocol=https >> \ >> - file://0001-fix-Fix-indention-in-cmake-generator-script.patch \ >> - >> file://0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch \ >> - >> file://0003-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE-.patch \ >> - file://0004-Add-source-files-at-library-definition-time.patch \ >> - file://0005-Add-CMake-options-for-SVE-SVE2-and-BF16-support.patch \ >> - file://0006-Allow-SVE-and-SVE2-support-to-be-disabled-in-CMake.patch \ >> - file://0007-Allow-ARMv7-builds-using-CMake.patch \ >> - >> file://0008-Fix-undefined-symbol-error-when-building-TensorInfo.patch \ >> + >> git://github.com/ARM-software/ComputeLibrary.git;branch=releases/arm_compute_52_7_0;protocol=https >> \ >> + >> file://0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch \ >> + >> file://0002-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE.patch \ >> + file://0003-Add-source-files-at-library-definition-time.patch \ >> + file://0004-Allow-ARMv7-builds-using-CMake.patch \ > > Mixing tabs/spaces. Don't care which you use in a multi-line list, > just be consistent. > > Andrew > Ok >> + >> file://0005-Fix-undefined-symbol-error-when-building-TensorInfo.patch \ >> + file://0006-Remove-TARGET-dependency.patch \ >> + file://0007-cmake-Generate-generic-library-name-instead-of.patch \ >> + file://0008-Add-FP16-source-path.patch \ >> " >> -SRCREV = "32bcced2af7feea6969dd1d22e58d0718dc488e3" >> +SRCREV = "c9a1fff898abd5109b759e8e16616519dc758fdd" >> # Only compatible with armv7a, armv7ve, and aarch64 >> COMPATIBLE_MACHINE = "(^$)" >> @@ -33,17 +33,26 @@ PACKAGECONFIG[cppthreads] = >> "-DARM_COMPUTE_CPPTHREADS=ON,-DARM_COMPUTE_CPPTHREAD >> PACKAGECONFIG[openmp] = >> "-DARM_COMPUTE_OPENMP=ON,-DARM_COMPUTE_OPENMP=OFF" >> EXTRA_OECMAKE:append:aarch64 = " \ >> - -DARM_COMPUTE_ARCH=armv8-a \ >> - -DENABLE_NEON=ON \ >> - -DENABLE_SVE=OFF \ >> - -DENABLE_SVE2=OFF \ >> + -DACL_MULTI_ISA=OFF \ >> + -DACL_ARCH_ISA=armv8-a \ >> + -DACL_BUILD_SVE=OFF \ >> + -DACL_BUILD_SVE2=OFF \ >> + -DCMAKE_BUILD_TYPE=Release \ >> + -DARM_COMPUTE_ENABLE_BF16=OFF \ >> + -DARM_COMPUTE_ENABLE_FP16=OFF \ >> + -DARM_COMPUTE_ENABLE_I8MM=OFF \ >> + -DARM_COMPUTE_ASSERTS_ENABLED=ON \ >> + -DARM_COMPUTE_ENABLE_FIXED_FORMAT_KERNELS=OFF \ >> " >> EXTRA_OECMAKE:append:arm = " \ >> - -DARM_COMPUTE_ARCH=armv7-a \ >> - -DENABLE_NEON=ON \ >> - -DENABLE_SVE=OFF \ >> - -DENABLE_SVE2=OFF \ >> + -DACL_MULTI_ISA=OFF \ >> + -DACL_ARCH_ISA=armv7 \ >> + -DACL_BUILD_SVE=OFF \ >> + -DACL_BUILD_SVE2=OFF \ >> + -DCMAKE_BUILD_TYPE=Release \ >> -DARM_COMPUTE_ENABLE_BF16=OFF \ >> + -DARM_COMPUTE_ENABLE_FP16=OFF \ >> + -DARM_COMPUTE_ASSERTS_ENABLED=ON \ >> -DARM_COMPUTE_ENABLE_FIXED_FORMAT_KERNELS=OFF \ >> " >> @@ -80,8 +89,15 @@ do_install:append() { >> install -m 0555 $example >> ${D}${bindir}/${PN}-${PV}/examples >> done >> fi >> + >> + if ${@bb.utils.contains('PACKAGECONFIG', 'tests', 'true', >> 'false', d)}; then >> + install -d ${D}${bindir}/${PN}-${PV}/tests >> + # Copy the validation and benchmark binaries from the >> build directory >> + install -m 0555 ${B}/arm_compute_validation >> ${D}${bindir}/${PN}-${PV}/tests >> + install -m 0555 ${B}/arm_compute_benchmark >> ${D}${bindir}/${PN}-${PV}/tests >> + fi >> } >> PACKAGES =+ "${PN}-tests ${PN}-examples" >> -FILES:${PN}-tests += "${libdir}/tests" >> +FILES:${PN}-tests += "${bindir}/*/tests" >> FILES:${PN}-examples += "${bindir}/*/examples" >