Re: [meta-arago][master][PATCH v2 1/4] arm-compute-library: upgrade 24.12 -> 52.07

On 05/03/26 11:50 pm, Andrew Davis wrote:
> On 3/5/26 11:34 AM, Pratham Deshmukh wrote:
>> We are migrating ARM Compute Library from v24.12 to the
>> latest version v52.07
>>
>> Removed Patches:
>>   • 0001-fix-Fix-indention-in-cmake-generator-script.patch
>>     - Upstream Link: 
>> https://github.com/ARM-software/ComputeLibrary/commit/e0c42ef651709fd284da3bedd2c98d420bd6fd1a
>>   • 0005-Add-CMake-options-for-SVE-SVE2-and-BF16-support.patch
>>     - No need for this patch for v52.07 ACL.
>>
>> Rebased Patches:
>>   • Following patches are updated with new commits
>>     - 0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch
>>     - 0003-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE-.patch
>>     - 0004-Add-source-files-at-library-definition-time.patch
>>     - 0006-Allow-SVE-and-SVE2-support-to-be-disabled-in-CMake.patch
>>     - 0007-Allow-ARMv7-builds-using-CMake.patch
>>     - 0008-Fix-undefined-symbol-error-when-building-TensorInfo.patch
>>
>> License-Update: Updated LIC_FILES_CHKSUM for MIT.txt, just checksum 
>> update due to minor
>> formatting/year changes in the license file for version v52.07.
>>
>> Signed-off-by: Pratham Deshmukh <[email protected]>
>> ---
>> Change Logs:
>>
>> v1 -> v2:
>>   - Fixed arm-compute-library recipe name
>>   - Fixed tabs/spacing issues
>>
>>   ...NABLE_NEON-in-code-for-checking-NEO.patch} |  72 ++---
>>   ...-indention-in-cmake-generator-script.patch | 130 ---------
>>   ...ENABLE_SVE-in-code-for-checking-SVE.patch} | 117 ++++-----
>>   ...ce-files-at-library-definition-time.patch} | 246 ++++++++++--------
>>   .../0004-Allow-ARMv7-builds-using-CMake.patch | 174 +++++++++++++
>>   ...ptions-for-SVE-SVE2-and-BF16-support.patch | 112 --------
>>   ...mbol-error-when-building-TensorInfo.patch} |  24 +-
>>   ...SVE2-support-to-be-disabled-in-CMake.patch |  91 -------
>>   .../0006-Remove-TARGET-dependency.patch       |  58 +++++
>>   .../0007-Allow-ARMv7-builds-using-CMake.patch |  86 ------
>>   ...rate-generic-library-name-instead-of.patch |  33 +++
>>   .../0008-Add-FP16-source-path.patch           |  28 ++
>>   ...24.12.bb => arm-compute-library_52.7.0.bb} |  56 ++--
>>   13 files changed, 551 insertions(+), 676 deletions(-)
>>   rename 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch 
>> => 0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch} 
>> (58%)
>>   delete mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0001-fix-Fix-indention-in-cmake-generator-script.patch
>>   rename 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0003-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE-.patch 
>> => 0002-Use-ARM_COMPUTE_ENABLE_SVE-in-code-for-checking-SVE.patch} (67%)
>>   rename 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0004-Add-source-files-at-library-definition-time.patch 
>> => 0003-Add-source-files-at-library-definition-time.patch} (24%)
>>   create mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0004-Allow-ARMv7-builds-using-CMake.patch
>>   delete mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0005-Add-CMake-options-for-SVE-SVE2-and-BF16-support.patch
>>   rename 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/{0008-Fix-undefined-symbol-error-when-building-TensorInfo.patch 
>> => 0005-Fix-undefined-symbol-error-when-building-TensorInfo.patch} (68%)
>>   delete mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0006-Allow-SVE-and-SVE2-support-to-be-disabled-in-CMake.patch
>>   create mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0006-Remove-TARGET-dependency.patch
>>   delete mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0007-Allow-ARMv7-builds-using-CMake.patch
>>   create mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0007-cmake-Generate-generic-library-name-instead-of.patch
>>   create mode 100644 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0008-Add-FP16-source-path.patch
>>   rename 
>> meta-arago-extras/recipes-devtools/arm-compute-library/{arm-compute-library_24.12.bb 
>> => arm-compute-library_52.7.0.bb} (58%)
>>
>> diff --git 
>> a/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch 
>> b/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch 
>>
>> similarity index 58%
>> rename from 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch
>> rename to 
>> meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch
>> index 1c33ac3c..b7dfa7b2 100644
>> --- 
>> a/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0002-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch
>> +++ 
>> b/meta-arago-extras/recipes-devtools/arm-compute-library/arm-compute-library/0001-Use-ARM_COMPUTE_ENABLE_NEON-in-code-for-checking-NEO.patch
>> @@ -1,7 +1,8 @@
>> -From 4350c56d14b7b68acd060d8331f3ade1fb74e167 Mon Sep 17 00:00:00 2001
>> -From: Andrew Davis <[email protected]>
>> -Date: Thu, 5 Dec 2024 09:21:23 -0600
>> -Subject: [PATCH] Use ARM_COMPUTE_ENABLE_NEON in code for checking 
>> NEON support
>> +From 6902148626781de2b4a2aec2c00fb6a13328209c Mon Sep 17 00:00:00 2001
>> +From: Pratham Deshmukh <[email protected]>
>> +Date: Wed, 4 Mar 2026 15:24:41 +0530
>> +Subject: [PATCH 1/8] Use ARM_COMPUTE_ENABLE_NEON in code for 
>> checking NEON
>> + support
>>     ENABLE_NEON is a flag used by the build systems. The flag is not 
>> used
>>   in code, instead ARM_COMPUTE_ENABLE_NEON is used everywhere.
>> @@ -11,19 +12,17 @@ use in code.
>>     Upstream-Status: Pending
>>   -Signed-off-by: Andrew Davis <[email protected]>
>> -Change-Id: I65f5e7411c99280e2dd8c187140909cefd1c6892
>> +Signed-off-by: Pratham Deshmukh <[email protected]>
>
> You take the signoff line and authorship for yourself, even in
> patches that you made little change to other than what was needed
> for rebasing them.
>
> Maybe some tools you are using are doing that automatically, but
> some might take issue with claiming their work as your own. I don't
> really care too much in this case, but under one condition: you
> should work these upstream so we don't have to carry them here in
> Arago for next LTS.
>
> Andrew
>

Hi Andrew,
Thank you for pointing this out. I sincerely apologize for the oversight;
I am still learning the nuances of patch authorship and attribution, and
it certainly wasn't my intention to claim your work as my own. I was simply
focused on getting the rebase working and wasn't aware of the protocol for
maintaining the original "From" line.

I will update the series to ensure you are credited as the author for 
these patches,
and I'll include my sign-off below yours.

I’ll take the lead on pushing these upstream so they don't have to be 
carried in
Arago indefinitely.

Pratham