Re: [meta-arago][master][PATCH v3 1/1] nnstreamer: Move test binaries to main package

Pratham Deshmukh <[email protected]> Thu, 12 Mar 2026 19:54:40 +0530
Newsgroups org.yoctoproject.lists.meta-arago
Message-ID <[email protected]>
On 12/03/26 7:17 pm, Andrew Davis wrote:
> On 3/12/26 8:09 AM, Pratham Deshmukh wrote:
>> Consolidate unittest executables into main nnstreamer
>> package instead of separate nnstreamer- tests package to
>> fix missing benchmark utilities.
>>
>> This resolves file packaging conflicts and ensures
>> unittest_filter_onnxruntime is available for ONNX
>> Runtime benchmarking without additional dependencies.
>>
>
> Why can't ONNXRuntime just depend on the -test package?
>
> Also this commit content looks to be mostly around fixing
> the "buildpaths" error, which isn't described in the commit
> message at all..
>
> Andrew
>
Do you mean to just add runtime dependeny to pull in nnstreamer-tests 
package?

I'll fix the commit, Thanks.

>> Fixes: 319271fe5fc8bc3016b1eb765784076af666b61b ("nnstreamer: upgrade 
>> 2.4.4 -> 2.6.0")
>>
>> Signed-off-by: Pratham Deshmukh <[email protected]>
>> ---
>> Change Logs:
>>   v2 -> v3:
>>   - Fix runitme dependencies issue for unittest_filter_onnxruntime.
>>   - Upgrade recipe to make it QA compliant.
>>   v1 -> v2:
>>   - Added fix commit hash in the commit message.
>>
>>   ...ute-build-paths-from-generated-test-.patch | 42 +++++++++++++++++++
>>   .../nnstreamer/nnstreamer_2.6.0.bb            | 15 +++----
>>   2 files changed, 48 insertions(+), 9 deletions(-)
>>   create mode 100644 
>> meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer/0001-fix-Remove-absolute-build-paths-from-generated-test-.patch
>>
>> diff --git 
>> a/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer/0001-fix-Remove-absolute-build-paths-from-generated-test-.patch 
>> b/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer/0001-fix-Remove-absolute-build-paths-from-generated-test-.patch 
>>
>> new file mode 100644
>> index 00000000..345b3eb2
>> --- /dev/null
>> +++ 
>> b/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer/0001-fix-Remove-absolute-build-paths-from-generated-test-.patch
>> @@ -0,0 +1,42 @@
>> +From a5f962b51431ac19c264b8b9baa78ff283a77efe Mon Sep 17 00:00:00 2001
>> +From: Pratham Deshmukh <[email protected]>
>> +Date: Tue, 10 Mar 2026 15:23:05 +0530
>> +Subject: [PATCH] fix: Remove absolute build paths from generated 
>> test files
>> +
>> +Replace meson.build_root() with relative paths in custom_filter_path
>> +to prevent Yocto buildpaths QA errors. The generated unittest files
>> +were embedding absolute build directory paths (e.g., /tmp/work/...)
>> +as string literals, which Yocto's QA system correctly flags as a
>> +build reproducibility issue.
>> +
>> +The runtime code already handles proper path resolution using
>> +NNSTREAMER_SOURCE_ROOT_PATH environment variable or relative
>> +fallbacks, so this change maintains full functionality
>> +while eliminating embedded build paths.
>> +
>> +Fixes: QA Issue "contains reference to TMPDIR [buildpaths]" in
>> +unittest_tizen_custom.cc and unittest_tizen_custom-set.cc
>> +
>> +Upstream-Status: Inappropriate [oe-specific]
>> +
>> +Signed-off-by: Pratham Deshmukh <[email protected]>
>> +---
>> + tests/nnstreamer_filter_extensions_common/meson.build | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/tests/nnstreamer_filter_extensions_common/meson.build 
>> b/tests/nnstreamer_filter_extensions_common/meson.build
>> +index ecd1878b..ba72ee20 100644
>> +--- a/tests/nnstreamer_filter_extensions_common/meson.build
>> ++++ b/tests/nnstreamer_filter_extensions_common/meson.build
>> +@@ -9,7 +9,7 @@ tizen_apptest_deps = [
>> + # Format for adding subplugin into extensions -
>> + # [name, extension abbreviation, dependencies, model file 
>> name/folder path/file path, test name]
>> + extensions = []
>> +-custom_filter_path = join_paths(meson.build_root(), 'tests', 
>> 'nnstreamer_example',
>> ++custom_filter_path = join_paths('tests', 'nnstreamer_example',
>> +     'libnnstreamer_customfilter_passthrough.' + so_ext)
>> + extensions += [['custom', 'custom', nnstreamer_unittest_deps, 
>> custom_filter_path, 'custom']]
>> + extensions += [['custom', 'custom', nnstreamer_unittest_deps, 
>> custom_filter_path, 'custom-set']]
>> +--
>> +2.34.1
>> +
>> diff --git 
>> a/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer_2.6.0.bb 
>> b/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer_2.6.0.bb
>> index c62589ac..7bf64408 100644
>> --- 
>> a/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer_2.6.0.bb
>> +++ 
>> b/meta-arago-extras/recipes-multimedia/nnstreamer/nnstreamer_2.6.0.bb
>> @@ -3,7 +3,11 @@ DESCRIPTION = "NNStreamer is a set of Gstreamer 
>> plugins that allow Gstreamer dev
>>   LICENSE = "LGPL-2.1-only"
>>   LIC_FILES_CHKSUM = 
>> "file://LICENSE;md5=c25e5c1949624d71896127788f1ba590"
>>   -SRC_URI = 
>> "git://github.com/nnstreamer/nnstreamer.git;branch=main;protocol=https"
>> +SRC_URI = " \
>> + 
>> git://github.com/nnstreamer/nnstreamer.git;branch=main;protocol=https \
>> + 
>> file://0001-fix-Remove-absolute-build-paths-from-generated-test-.patch \
>> +"
>> +
>>   SRCREV = "b970e9eff6bfb4e915463842422fe14bb2e53f84"
>>     # Only compatible with armv7a, armv7ve, and aarch64
>> @@ -53,16 +57,9 @@ FILES:${PN} += "\
>>       ${libdir}/gstreamer-1.0/*.so \
>>       ${libdir}/nnstreamer/* \
>>       ${sysconfdir}/nnstreamer.ini \
>> -"
>> -INSANE_SKIP:${PN} += "dev-so"
>> -
>> -PACKAGES =+ "${PN}-tests"
>> -
>> -FILES:${PN}-tests += "\
>> -    ${libdir}/nnstreamer/customfilters/* \
>>       ${bindir}/unittest-nnstreamer/* \
>>   "
>> -INSANE_SKIP:${PN}-tests += "buildpaths"
>> +INSANE_SKIP:${PN} += "dev-so"
>>     FILES:${PN}-dev = "\
>>       ${includedir}/nnstreamer/* \
>