Re: [meta-arago][master][PATCH 1/2] libsdl2: Add tests package

On Tue, Mar 17, 2026 at 02:29:16PM -0500, Antonios Christidis wrote:
> 
> On 3/17/26 2:14 PM, Denys Dmytriyenko wrote:
> >On Tue, Mar 17, 2026 at 01:57:23PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> >>From: Antonios Christidis <[email protected]>
> >>
> >>The software provides tests, configure cmake to build and install them.
> >>Package the tests in -tests package.
> >This might be useful to get it upstreamed as a new PACKAGECONFIG to OE-Core...
> 
> Thank you for the idea, I'll keep that in mind.
> 
> >
> >>Signed-off-by: Antonios Christidis <[email protected]>
> >>---
> >>  meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 6 ++++++
> >>  meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
> >>  2 files changed, 10 insertions(+)
> >>  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >>  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >>
> >>diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >>new file mode 100644
> >>index 00000000..f33ff909
> >>--- /dev/null
> >>+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >>@@ -0,0 +1,6 @@
> >>+EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
> >>+                         -DSDL_INSTALL_TESTS=ON \
> >>+                       "
> >There's no reason for :append here, while += could work just fine.
> Do you want me to send a v2 for this ?
> >>+PACKAGE_BEFORE_PN = "${PN}-tests"
> >>+FILES:${PN}-tests += "${libexecdir} ${datadir}/installed-tests/SDL2"
> >>+FILES:${PN}-tests:class-nativesdk += "${libexecdir} ${datadir}/installed-tests/SDL2"
> >If the values for these 2 are identical, why do you need to set
> >class-nativesdk variant explixitly?
> 
> Ryan observed an issue when class-nativesdk variant wasn't set
> explicitly on scarthgap branch.
> 
> Link: https://patchwork.yoctoproject.org/project/arago/patch/[email protected]/#31054

Ah, right, we had that discussion back in September... Still not sure why it 
was failing.


> >>diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >>new file mode 100644
> >>index 00000000..385aa801
> >>--- /dev/null
> >>+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >>@@ -0,0 +1,4 @@
> >>+LIBSDL2_TI = ""
> >>+LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
> >>+
> >>+require ${LIBSDL2_TI}
> >>-- 
> >>2.34.1