Re: [meta-arm] [PATCH] edk2-firmware: fix PlatformStandaloneMmRpmb.dsc build

Hi,

On Tue, Jan 14, 2025 at 10:20:09AM -0500, Jon Mason via lists.yoctoproject.org wrote:
> On Tue, Jan 14, 2025 at 9:43 AM Mikko Rapeli <[email protected]> wrote:
> > On Tue, Jan 14, 2025 at 09:16:15AM -0500, Jon Mason wrote:
> > > On Tue, Jan 14, 2025 at 11:41:54AM +0200, Mikko Rapeli wrote:
> > > > With backported patch from upstream. Error was:
> > > >
> > > > | build.py...
> > > > | /home/builder/src/base/repo/build/tmp_rockpi4b/work/rockpi4b-poky-linux/edk2-firmware/202408/edk2/edk2-platforms/Platform/StandaloneMm/PlatformS
> > > > tandaloneMmPkg/PlatformStandaloneMmRpmb.dsc(...): error 4000: Instance of library class [HobPrintLib] is not found
> > > > |       in [/home/builder/src/base/repo/build/tmp_rockpi4b/work/rockpi4b-poky-linux/edk2-firmware/202408/edk2/StandaloneMmPkg/Core/StandaloneMmCor
> > > > e.inf] [AARCH64]
> > > > |       consumed by module [/home/builder/src/base/repo/build/tmp_rockpi4b/work/rockpi4b-poky-linux/edk2-firmware/202408/edk2/StandaloneMmPkg/Core
> > > > /StandaloneMmCore.inf]
> > > >
> > > > Signed-off-by: Mikko Rapeli <[email protected]>
> > >
> > > I'm seeing this patch fail to apply (as part of the edk2 build
> > > process) on every edk2 platform
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673217
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673227
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673281
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673312
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673331
> > > https://gitlab.com/jonmason00/meta-arm/-/jobs/8844673346
> >
> > Oh, I did not see this. I will try to reproduce. Seems to be line ending
> > issue. edk2 sources use Windows ones. I hope mailing list patch doesn't change
> > something...
> 
> Talking to Ross, and he reminded me that email messes up edk2 patches
> (specifically).  Do you have a git tree with this patch that I can
> cherry-pick from?

Yes, git repo https://gitlab.com/mikko.rapeli/meta-arm.git and branch
edk2-firmware_rpmb_fix has commit 8a3cef62ad33fdc91f6be84331cae1171211feb5

Cheers,

-Mikko