Re: [meta-arm] if this meta-arm .inc file missing a trailing colon?
Jon Mason <[email protected]>
| Newsgroups | org.yoctoproject.lists.meta-arm |
|---|---|
| Message-ID | <CAPoiz9y+DE7ij-tMH--9zRzz++JQR5xdLYQ8Xt77EEpN7C52YQ@mail.gmail.com> |
On Wed, Jun 18, 2025 at 8:41 AM Robert P. J. Day <[email protected]> wrote: > > On Wed, 18 Jun 2025, Jon Mason wrote: > > > On Wed, Jun 18, 2025 at 6:07 AM Robert P. J. Day via > > lists.yoctoproject.org <[email protected]> > > wrote: > > > > > > > > > here: > > > > > > https://git.yoctoproject.org/meta-arm/tree/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-base.inc#n7 > > > > > > should there not be a trailing ":" at the end of that prepend > > > operation? > > > > I think you are correct, and a quick grep shows 10 other instances of > > this in meta-arm. Thanks for the heads up. > > > > I wonder if there is a way to add a check for prepend and > > FILESEXTRAPATHS in the sanity checkers. > > i'm not sure where you counted 10 other instances but i did notice > the following, which confused me briefly: this appears to be an > example that is missing the trailing colon: > > meta-arm/recipes-kernel/linux/arm-ffa-transport.inc: > FILESEXTRAPATHS:prepend := "${ARMFILESPATHS}" > > except that the variable ARMFILESPATHS is defined to (you guessed it) > have a trailing colon. > > aaarrrggghhh. > > i hate that sort of thing. Yes, this is what bit me. I need another cup of coffee. Thanks. I'll credit you in the committ. > > rday