Re: [meta-ti][master/wrynose][PATCH v2] ti-linux-fw: Remove default SUMMARY line

On 6/24/26 3:37 PM, Denys Dmytriyenko wrote:
> On Wed, Jun 24, 2026 at 03:30:26PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
>> All firmware that includes this helper should set their own SUMMARY line.
>> Currently all do (other than ti-adc-fw which we fix here), but they often
>> include this file after setting their own SUMMARY, so this common one
>> overwrites the correct one. Remove this default SUMMARY.
> 
> How about flipping it the other way around?
> 
> In the common .inc file we set:
> 
> SUMMARY = "Prebuild binary firmware"
> 
> And in specific firmware recioes we clarify:
> 
> SUMMARY .= " for TI ADC PCM6240 configuration"
> 
> That way it won't matter if the inclusion happens before or after setting the
> specific SUMMARY and it won't be completely empty (albeit generic) if someone
> forgets setting SUMMARY in the recipe.
> 

It might technically work, but I'd rather we throw a warning if someone forgets
their SUMMARY line rather than just taking a super generic fallback. If we allow
fallbacks like that what stops us from having

SUMMARY = "Yocto recipe"

in some main conf and hope recipes add

SUMMARY .= " for Linux kernel on TI devices"

Andrew

> 
>> Signed-off-by: Andrew Davis <[email protected]>
>> ---
>>
>> Changes for v2:
>>   - Update ti-adc-fw so it has a SUMMARY
>>
>>   meta-ti-bsp/recipes-bsp/ti-adc-fw/ti-adc-fw.bb      | 2 +-
>>   meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 2 --
>>   2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/ti-adc-fw/ti-adc-fw.bb b/meta-ti-bsp/recipes-bsp/ti-adc-fw/ti-adc-fw.bb
>> index ad025483..0b70d69d 100644
>> --- a/meta-ti-bsp/recipes-bsp/ti-adc-fw/ti-adc-fw.bb
>> +++ b/meta-ti-bsp/recipes-bsp/ti-adc-fw/ti-adc-fw.bb
>> @@ -1,4 +1,4 @@
>> -DESCRIPTION = "TI ADC PCM6240 config prebuild binary firmware"
>> +SUMMARY = "TI ADC PCM6240 config prebuild binary firmware"
>>   
>>   require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>>   
>> diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>> index 126c46df..d343a6aa 100644
>> --- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>> +++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>> @@ -1,5 +1,3 @@
>> -SUMMARY = "Common include for TI Linux firmware"
>> -
>>   LICENSE = "TI-TFL"
>>   LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=b5aebf0668bdf95621259288c4a46d76"
>>   
>> -- 
>> 2.39.2