Re: [meta-ti][master/wrynose][PATCH v2] ti-linux-fw: Remove default SUMMARY line
"Robert P. J. Day" <[email protected]> Wed, 24 Jun 2026 17:00:14 -0400 (EDT)
| Newsgroups | org.yoctoproject.lists.meta-ti |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 24 Jun 2026, Denys Dmytriyenko wrote: > On Wed, Jun 24, 2026 at 03:47:52PM -0500, Andrew Davis via lists.yoctoproject.org wrote: > > On 6/24/26 3:37 PM, Denys Dmytriyenko wrote: > > >On Wed, Jun 24, 2026 at 03:30:26PM -0500, Andrew Davis via lists.yoctoproject.org wrote: > > >>All firmware that includes this helper should set their own SUMMARY line. > > >>Currently all do (other than ti-adc-fw which we fix here), but they often > > >>include this file after setting their own SUMMARY, so this common one > > >>overwrites the correct one. Remove this default SUMMARY. > > > > > >How about flipping it the other way around? > > > > > >In the common .inc file we set: > > > > > >SUMMARY = "Prebuild binary firmware" > > > > > >And in specific firmware recioes we clarify: > > > > > >SUMMARY .= " for TI ADC PCM6240 configuration" > > > > > >That way it won't matter if the inclusion happens before or after setting the > > >specific SUMMARY and it won't be completely empty (albeit generic) if someone > > >forgets setting SUMMARY in the recipe. > > > > > > > It might technically work, but I'd rather we throw a warning if someone forgets > > their SUMMARY line rather than just taking a super generic fallback. If we allow > > fallbacks like that what stops us from having > > > > SUMMARY = "Yocto recipe" > > > > in some main conf and hope recipes add > > > > SUMMARY .= " for Linux kernel on TI devices" > > There won't be any warning, as OE-Core has defaults for SUMMARY and > DESCRIPTION: > > https://git.openembedded.org/openembedded-core/tree/meta/conf/bitbake.conf#n276 i literally added a note about that to the YP docs in the last few days. rday