Re: [meta-ti][master/wrynose][PATCH 3/3] ti-rpmsg-char: Update to latest with CMake support
Andrew Davis <[email protected]> Thu, 2 Jul 2026 09:46:14 -0500
| Newsgroups | org.yoctoproject.lists.meta-ti |
|---|---|
| Message-ID | <[email protected]> |
On 7/1/26 5:15 PM, Ryan Eatmon wrote: >=20 > Did you do a test build with this?=C2=A0 I'm getting this error for all= k3 platforms that depend on ti-rpmsg-char-staticdev: >=20 > Solver encountered 1 problem(s): > Problem 1/1: > =C2=A0 - package packagegroup-arago-toolchain-tisdk-target-1.0-r14.7.a= m62axx_evm requires packagegroup-arago-addons-sdk-target, but none of the= providers can be installed > =C2=A0 - conflicting requests > =C2=A0 - nothing provides ti-rpmsg-char-staticdev needed by packagegro= up-arago-addons-sdk-target-1.0-r44.0.am62axx_evm >=20 >=20 > Either we should remove the dependency or fix the new recipe. >=20 >=20 > I'm going to keep patch #2 from this series, but #3 needs to either fix= the issue, or remove the dependency. >=20 Let's go with removing that dependency, there are very few dependencies o= n -staticdev packages to begin with, so dropping one of the few remaining o= nes seems like the right direction here. Patch sent[0]. Once that is in meta-= arago it should be safe to take patch #3. As for your question on build testing, the answer is yes and no. I try to test build what I think are relevant packages, in this case `ti-rpmsg-cha= r` and some dependent packages (like `ti-librpmsg-dma`) to verify they still= work. Lastly I will usually do a full image build, but rarely a full SDK build (as I don't have a spare super-computer :D), and so in this case there wa= s a miss on my part. I realize now that this would have failed early in the build so simply kicking off an SDK build can find these kinds of issues (even if I don't have the time or compute power to run the whole build). Andrew [0] https://lists.yoctoproject.org/g/meta-arago/message/17579 >=20 > On 6/24/2026 1:32 PM, Andrew Davis wrote: >> This project now uses CMake. This allows us to cleanup this recipe in = 3 >> ways: >> >> =C2=A0 - Remove patch for includedir and libdir as CMake handles this = correctly >> =C2=A0 - Combine in the in the examples recipe, CMake builds the examp= les along >> =C2=A0=C2=A0=C2=A0 with the library in one step. >> =C2=A0 - As there is now only one recipe, merge the .inc into the one = .bb file >> >> Signed-off-by: Andrew Davis <[email protected]> >> --- >> =C2=A0 ...-Remove-use-of-includedir-and-libdir.patch | 44 ------------= ------- >> =C2=A0 .../ti-rpmsg-char-examples_git.bb=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 13 ------ >> =C2=A0 .../ti-rpmsg-char/ti-rpmsg-char.inc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 15 ------- >> =C2=A0 .../ti-rpmsg-char/ti-rpmsg-char_git.bb=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 20 +++++++-- >> =C2=A0 4 files changed, 17 insertions(+), 75 deletions(-) >> =C2=A0 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpms= g-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch >> =C2=A0 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpms= g-char-examples_git.bb >> =C2=A0 delete mode 100644 meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpms= g-char.inc >> >> diff --git a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-exampl= es/0001-examples-Remove-use-of-includedir-and-libdir.patch b/meta-ti-bsp/= recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001-examples-Remove-use-= of-includedir-and-libdir.patch >> deleted file mode 100644 >> index 3539e8d9..00000000 >> --- a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples/0001= -examples-Remove-use-of-includedir-and-libdir.patch >> +++ /dev/null >> @@ -1,44 +0,0 @@ >> -From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 200= 1 >> -From: Khem Raj <[email protected]> >> -Date: Sat, 24 Oct 2020 23:46:39 -0700 >> -Subject: [PATCH] examples: Remove use of includedir and libdir >> - >> -These point to standard include and library paths which already are u= sed >> -from sysroot relative paths secondly, they use absolute paths which >> -means we are asking to add -I/usr/include which might be ok in a nati= ve >> -build but not in cross build. This helps mitigate QA errors found wit= h >> -OE build system since it finds it adding host include and library sea= rch >> -paths to linker/compiler commandline >> - >> -Upstream-Status: Pending >> -Signed-off-by: Khem Raj <[email protected]> >> ---- >> - examples/Makefile.am | 6 +----- >> - 1 file changed, 1 insertion(+), 5 deletions(-) >> - >> -diff --git a/examples/Makefile.am b/examples/Makefile.am >> -index da34204..34ac7a8 100644 >> ---- a/examples/Makefile.am >> -+++ b/examples/Makefile.am >> -@@ -1,6 +1,4 @@ >> --INCLUDE =3D -I${includedir} >> --=20 >> --AM_CFLAGS =3D -Wall -g -O2 $(INCLUDE) >> -+AM_CFLAGS =3D -Wall -g -O2 >> - >> - bin_PROGRAMS =3D rpmsg_char_simple rpmsg_char_benchmark >> - >> -@@ -8,10 +6,8 @@ bin_PROGRAMS =3D rpmsg_char_simple rpmsg_char_benchm= ark >> - rpmsg_char_simple_SOURCES =3D rpmsg_char_simple.c >> - rpmsg_char_simple_CPPFLAGS =3D $(AM_CFLAGS) >> - rpmsg_char_simple_LDADD =3D -lpthread -lti_rpmsg_char >> --rpmsg_char_simple_LDFLAGS =3D -L${libdir} >> - >> - # rpmsg_char_benchmark program >> - rpmsg_char_benchmark_SOURCES =3D rpmsg_char_benchmark.c >> - rpmsg_char_benchmark_CPPFLAGS =3D $(AM_CFLAGS) >> - rpmsg_char_benchmark_LDADD =3D -lpthread -lti_rpmsg_char >> --rpmsg_char_benchmark_LDFLAGS =3D -L${libdir} >> --- >> -2.29.1 >> - >> diff --git a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-exampl= es_git.bb b/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_g= it.bb >> deleted file mode 100644 >> index cbe4d7fd..00000000 >> --- a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char-examples_git.= bb >> +++ /dev/null >> @@ -1,13 +0,0 @@ >> -SUMMARY =3D "TI RPMsg Char Sample Applications and Tests" >> - >> -require ti-rpmsg-char.inc >> - >> -SRC_URI +=3D "file://0001-examples-Remove-use-of-includedir-and-libdi= r.patch" >> - >> -DEPENDS =3D "ti-rpmsg-char" >> - >> -inherit autotools pkgconfig >> - >> -EXTRA_OEMAKE =3D "-C ${B}/examples" >> - >> -PR =3D "r0" >> diff --git a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc b/= meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc >> deleted file mode 100644 >> index f9fb0f25..00000000 >> --- a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char.inc >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -SUMMARY =3D "TI RPMsg Char Utility Library" >> - >> -LICENSE =3D "BSD-3-Clause" >> -LIC_FILES_CHKSUM =3D "file://${S}/src/rpmsg_char.c;beginline=3D1;endl= ine=3D31;md5=3D71987db43a2159cff5ea00505c6fce58" >> - >> -PROTOCOL =3D "https" >> -BRANCH =3D "master" >> -SRC_URI =3D "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=3D= ${PROTOCOL};branch=3D${BRANCH};" >> - >> -# 0.6.11 release >> -SRCREV =3D "dd4783422bf4fbed1015bfaa51054e40057b4f04" >> - >> -PV =3D "0.6.11+git" >> - >> -COMPATIBLE_MACHINE =3D "^(k3)$" >> diff --git a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb= b/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb >> index 50565300..a0043caf 100644 >> --- a/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb >> +++ b/meta-ti-bsp/recipes-ti/ti-rpmsg-char/ti-rpmsg-char_git.bb >> @@ -1,9 +1,23 @@ >> =C2=A0 SUMMARY =3D "TI RPMsg Char Utility Library" >> -require ti-rpmsg-char.inc >> +LICENSE =3D "BSD-3-Clause" >> +LIC_FILES_CHKSUM =3D "file://${S}/src/rpmsg_char.c;beginline=3D1;endl= ine=3D31;md5=3D71987db43a2159cff5ea00505c6fce58" >> -inherit autotools pkgconfig >> +PROTOCOL =3D "https" >> +BRANCH =3D "master" >> +SRC_URI =3D "git://git.ti.com/git/rpmsg/ti-rpmsg-char.git;protocol=3D= ${PROTOCOL};branch=3D${BRANCH};" >> +# 0.6.11 release >> +SRCREV =3D "e36103aac7d9f6d64125eb917d3c69022cb86e0b" >> + >> +PV =3D "0.6.11+git" >> =C2=A0 PR =3D "r0" >> -DISABLE_STATIC =3D "" >> +COMPATIBLE_MACHINE =3D "^(k3)$" >> + >> +inherit cmake >> + >> +PACKAGES =3D+ "${PN}-examples" >> +FILES:${PN}-examples +=3D "${bindir}/rpmsg_char_simple" >> +FILES:${PN}-examples +=3D "${bindir}/rpmsg_char_benchmark" >> +RDEPENDS:${PN}-examples +=3D "${PN}" >=20