Re: [meta-virtualization][PATCH] irqbalance: Fix PACKAGECONFIG[systemd] parameter

Bruce Ashfield <[email protected]>
Newsgroups org.yoctoproject.lists.meta-virtualization
Message-ID <CADkTA4OmUhcmcLHtCD8uGBA+u3UT4PtKx-BuuZryD6LAvUo2Bg@mail.gmail.com>
On Sun, Jan 25, 2026 at 10:44 PM Yiding Liu (Fujitsu) via
lists.yoctoproject.org <[email protected]>
wrote:

> irqbalance: correct to install /etc/default for sysvinit
>
> 1. This commit uses option --with-pkgconfdir to correct to install
> /etc/default
>    Without this fix, there will show do_package QA Issue
>    ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance:
> Files/directories were installed but not shipped in any package:
>      /usr/etc
>      /usr/etc/default
>      /usr/etc/default/irqbalance.env
>
> 2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
>
> Signed-off-by: Liu Yiding <[email protected]>
> ---
>  recipes-extended/irqbalance/irqbalance.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/irqbalance/irqbalance.inc
> b/recipes-extended/irqbalance/irqbalance.inc
> index 35b6388e..b7b34a0b 100644
> --- a/recipes-extended/irqbalance/irqbalance.inc
> +++ b/recipes-extended/irqbalance/irqbalance.inc
> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>                    "
>
>  DEPENDS = "glib-2.0"
> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
> '', d)}"
>
>  INITSCRIPT_NAME = "irqbalanced"
>  INITSCRIPT_PARAMS = "defaults"
> @@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
>  SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
>
>  EXTRA_OECONF = "--program-transform-name= \
> +                --with-pkgconfdir=${sysconfdir} \
>                "
>
>  # let the recipes or appends define options
> @@ -34,7 +34,7 @@ PACKAGECONFIG ?=
> "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
>  #
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
>  PACKAGECONFIG[libcap-ng] =
> "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
> -PACKAGECONFIG[systemd] = "--with-systemd
> --with-pkgconfdir=${sysconfdir},,,"
>

We should explain this change more in the commit message.
irqbalance uses autotools and that's one of the classes that
is supposed to pick up PACKAGECONFIG_CONFARGS.

Which is what that first field is trying to do. So is there an
issue in the configure that isn't passing it through ? Is it
the combination of that plus our EXTRA_OECONF ?

Bruce

+PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
>
>  do_install () {
>          oe_runmake 'DESTDIR=${D}' install
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9552):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9552
> Mute This Topic: https://lists.yoctoproject.org/mt/117463389/1050810
> Group Owner: [email protected]
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> [email protected]]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.