Re: [meta-virtualization][PATCH] xen-guest-bundle: require "xen" DISTRO_FEATURE
Bruce Ashfield <[email protected]>
| Newsgroups | org.yoctoproject.lists.meta-virtualization |
|---|---|
| Message-ID | <CADkTA4NsrvuoTzOaxDq8pozw_OuZB2XGp3Eaje2jHEDTwKH99g@mail.gmail.com> |
On Thu, Mar 5, 2026 at 9:26 AM Dmitry Baryshkov < [email protected]> wrote: > On 05/03/2026 06:46, Bruce Ashfield wrote: > > > > > > On Wed, Mar 4, 2026 at 11:30 PM Dmitry Baryshkov via > > lists.yoctoproject.org <http://lists.yoctoproject.org> > > <[email protected] > > <mailto:[email protected]>> wrote: > > > > Building guest bundles makes sense only if "xen" feature is enabled > in > > DISTRO_FEATURES. Skip all Xen guest bundle recipes if it is not a > part > > of the DISTRO_FEATURES. > > > > > > Sure, but you are just describing what is in the patch. > > > > What problem was this actually causing ? > > When building world (or when running yocto-check-layers against a > layer depending on meta-virtualization): > > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', > 'example-xen-guest-bundle', 'xen-guest-image-minimal'] > Aha. That's what needs to be in the commit message! I'd prefer the feature check in the recipes themselves (and clearly I missed some when doing the work). Distro / feature requirements just aren't visible enough when they are in a bbclass versus the recipe (from my point of view). In fact, I don't even think the recipes make sense in a world build at all, and I should probably just bulk exclude them. Thoughts ? Bruce > > > > -- > With best wishes > Dmitry > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II