Re: [meta-virtualization][PATCH] libvirt: Drop the deprecated workaround

On 4/21/26 12:46 AM, Zhixiong Chi via lists.yoctoproject.org wrote:
> The workaround is not needed anymore as the systemd supporting.
> The libvirtd.service Type has been changed from notify to notify-reload,
> so the final Type will be 'forking-reload', that's invalid for systemd.
> Here we delete it to avoid the following output information:
>> /lib/systemd/system/libvirtd.service:29: Failed to parse Type=forking-reload, ignoring: Invalid argument
> 
> Signed-off-by: Zhixiong Chi <[email protected]>
> ---
>   recipes-extended/libvirt/libvirt_git.bb | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/recipes-extended/libvirt/libvirt_git.bb b/recipes-extended/libvirt/libvirt_git.bb
> index 62931d17..b5b0a5f2 100644
> --- a/recipes-extended/libvirt/libvirt_git.bb
> +++ b/recipes-extended/libvirt/libvirt_git.bb
> @@ -232,13 +232,6 @@ do_install:append() {
>                   mv ${D}${prefix}/lib/systemd/system/* ${D}${systemd_system_unitdir}
>                   rmdir ${D}${prefix}/lib/systemd/system ${D}${prefix}/lib/systemd
>               fi
> -
> -	    # We can't use 'notify' when we don't support 'sd_notify' dbus capabilities.
> -	    # Change default LIBVIRTD_ARGS to start libvirtd in the right mode.
> -	    sed -i -e 's/Type=notify/Type=forking/' \
> -	           -e '/Type=forking/a PIDFile=/run/libvirtd.pid' \
> -	           -e 's/\(Environment=LIBVIRTD_ARGS="--timeout 120"\)/#\1\nEnvironment=LIBVIRTD_ARGS="--listen --daemon"/' \
> -		   ${D}/${systemd_system_unitdir}/libvirtd.service
>   	fi


This should be patch to source, that way it is better for tracking changes.

>   
>   	# The /run/libvirt directories created by the Makefile are
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9719): https://lists.yoctoproject.org/g/meta-virtualization/message/9719
> Mute This Topic: https://lists.yoctoproject.org/mt/118934411/1997914
> Group Owner: [email protected]
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
> -=-=-=-=-=-=-=-=-=-=-=-
>