Re: [PATCH v3 0/2] Add crosvm recipe to meta-virtualization
Bruce Ashfield <[email protected]> Mon, 20 Jul 2026 14:11:41 -0700 (PDT)
| Newsgroups | org.yoctoproject.lists.meta-virtualization |
|---|---|
| Message-ID | <[email protected]> |
Hi Keerthivasan,
Thanks for the v3, the series has been applied to master and is
staged on master-next.
Nearly every item from the last round is picked up: postfunc-remove is
in place, the LIC_FILES_CHKSUM now points at the in-source LICENSE,
the bindgen wiring (clang-native + LIBCLANG_PATH +
BINDGEN_EXTRA_CLANG_ARGS) is there, BBCLASSEXTEND = "native" is
dropped, the "uage" typo is fixed in the image recipe, and the
KVM_MODULES:aarch64 empty override is kept with a tightened
comment.
The inline TODO about breaking wayland DEPENDS into pkgconfig-mapped
feature flags is a good spot for that follow-up.
One process point for the next round (and for any future series):
please include a "Changes in vN" section in the cover letter. This v3
cover is byte-identical to the v2 cover, so the only way to see what
changed was to diff the actual patches. That works for a 2-patch
series, but it defeats archiving: when we (or anyone else) need to
track a still-open TODO across versions later, the cover-letter
changelog is the canonical place to find it.
Two things I flagged in earlier reviews that this v3 doesn't touch:
1. The single BSD-3-Clause LICENSE declaration for a 966-crate tree
almost certainly under-represents the actual license mix. Not
blocking — other recipes in the layer have the same issue and it's
on my broader cleanup list — but a per-recipe TODO comment would
help track it.
2. The wayland unconditional DEPENDS. You've noted the intent
inline; a real PACKAGECONFIG follow-up is still open.
Neither is blocking the merge; the series is in as-is on master
and master-next.
Recording them here so the trail is on the list.
Bruce