Re: [PATCH v3] Add genericarm64 MACHINE

On Wed, Feb 28, 2024 at 11:44:15AM +0000, [email protected] wrote:

> From: Ross Burton <[email protected]>
> 
> This is a new 64-bit "generic" Arm machine, that expects the hardware to
> be SystemReady IR compatible.

A general comment is that some parts of the documentation / comments say
"SystemReady" and others "SystemReady IR". Since there's differences
between IR/ES/SR and that includes userspace, we should be clear I think
that this is just IR. For example...

[snip]
> diff --git a/meta-yocto-bsp/conf/machine/genericarm64.conf b/meta-yocto-bsp/conf/machine/genericarm64.conf
> new file mode 100644
> index 00000000000..83f1aca137a
> --- /dev/null
> +++ b/meta-yocto-bsp/conf/machine/genericarm64.conf
> @@ -0,0 +1,29 @@
> +#@TYPE: Machine
> +#@NAME: genericarm64
> +#@DESCRIPTION: Generic Arm64 machine for typical SystemReady platforms, which
> +#have working firmware and boot via EFI.
> +
> +require conf/machine/include/arm/arch-armv8a.inc
> +
> +# Arm Base System Architecture says v8.0+ is allowed, but FEAT_CRC32 is required
> +DEFAULTTUNE = "armv8a-crc"
> +
> +MACHINE_FEATURES = "acpi alsa bluetooth efi keyboard pci qemu-usermode rtc screen usbhost vfat wifi"

acpi isn't required for IR, just ES and SR.

-- 
Tom