Re: [poky] [PATCH] poky.conf: Set the distro name to "scarthgap"
Bruce Ashfield <[email protected]>
| Newsgroups | org.yoctoproject.lists.poky |
|---|---|
| Message-ID | <CADkTA4OjpfO2fbvpSP-zmkHL_AXT+vnOt-Hb28r8dZSp3HHDxA@mail.gmail.com> |
On Wed, Mar 6, 2024 at 11:59 AM Peter Kjellerstedt <[email protected]> wrote: > > > -----Original Message----- > > From: [email protected] <[email protected]> On Behalf > > Of Bruce Ashfield > > Sent: den 6 mars 2024 16:49 > > To: Peter Kjellerstedt <[email protected]> > > Cc: [email protected] > > Subject: Re: [poky] [PATCH] poky.conf: Set the distro name to "scarthgap" > > > > On Wed, Mar 6, 2024 at 10:30 AM Peter Kjellerstedt > > <[email protected]> wrote: > > > > > > > -----Original Message----- > > > > From: [email protected] <[email protected]> On > > Behalf Of Bruce Ashfield > > > > Sent: den 6 mars 2024 15:30 > > > > To: Peter Kjellerstedt <[email protected]> > > > > Cc: [email protected] > > > > Subject: Re: [poky] [PATCH] poky.conf: Set the distro name to > > "scarthgap" > > > > > > > > On Wed, Mar 6, 2024 at 9:11 AM Peter Kjellerstedt > > <[email protected]> wrote: > > > > > > > > > > *ping* > > > > > > > > > > I can't speak for others, but at least we have started our > > preparations for > > > > > the Scarthgap upgrade so that we are ready when it is released, thus > > it would > > > > > help if DISTRO_CODENAME reflected the reality better. > > > > > > > > I can't speak for Richard, but I know when I get patches like this > > > > for areas I maintain, they would have been better just as an email > > > > asking when it is expected that the codename / whatever will be > > > > updated. > > > > > > > > Making this change is obviously something Richard can more easily > > > > do himself when he's happy with the content and not dealing with > > > > bigger issues (when everything is burning and late, this is low on the > > > > priority list). > > > > > > > > Handling a patch for something that he's responsible for (declaring > > > > that the branch is almost ready for the release) is more effort than > > > > it is worth. > > > > > > > > Bruce > > > > > > Well, the DISTRO_CODENAME is normally updated relatively soon after the > > > upgrade rather than just before the next upgrade, typically at the same > > > time as the DISTRO_VERSION is set to its post-upgrade value. I do not > > > know why that did not happen this time. > > > > I didn't say that asking the question wasn't valid, I said doing it > > with a patch, following by a *ping* email, comes across as not > > being particularly sensitive to the current (well known) issues with > > late merging features to M3. > > I am just following the established procedure for integrating changes > to OE: send a patch, wait for it to be accepted or receive feedback, > if nothing happens within a reasonable time frame (where I typically > wait about a week), then ping the patch as it may have been missed. > > Since I expect us to be using M3 to do our preparations for the upcoming > release, I thought it appropriate to give the patch a little nudge since > simple things like this are easily overlooked when focusing on the more > problematic integrations. > > And the reason I sent it as a patch rather than a request to go and > change the value is because I assume it is a faster/easier process to > take a prepared patch rather than to manually do the change (even if > it is just a one line change like this). Let's agree to disagree on the message and work that is required when you send a patch for a common set of changes that are typically done by the maintainer. Cheers, Bruce > > > Richard obviously knows what has to be done to prepare for a > > release, and if it hasn't been done yet, there are likely reasons > > for that. > > > > Bruce > > //Peter > > > > And the reason I ask for it to be updated to match the content is of > > > course that we sometimes use it when there is a need to differentiate > > > between how things are done in the current version and in the upcoming > > > release. > > > > > > //Peter > > > > > > > > //Peter > > > > > > > > > > > -----Original Message----- > > > > > > From: [email protected] <[email protected]> On > > Behalf Of Peter Kjellerstedt > > > > > > Sent: den 27 februari 2024 21:45 > > > > > > To: [email protected] > > > > > > Subject: [poky] [PATCH] poky.conf: Set the distro name to > > "scarthgap" > > > > > > > > > > > > Signed-off-by: Peter Kjellerstedt <[email protected]> > > > > > > --- > > > > > > > > > > > > It's been a long time since this diverged from Nanbield. > > > > > > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/meta-poky/conf/distro/poky.conf b/meta- > > poky/conf/distro/poky.conf > > > > > > index 3b7bc66780..e59ad974d0 100644 > > > > > > --- a/meta-poky/conf/distro/poky.conf > > > > > > +++ b/meta-poky/conf/distro/poky.conf > > > > > > @@ -1,7 +1,7 @@ > > > > > > DISTRO = "poky" > > > > > > DISTRO_NAME = "Poky (Yocto Project Reference Distro)" > > > > > > DISTRO_VERSION = "4.3+snapshot-${METADATA_REVISION}" > > > > > > -DISTRO_CODENAME = "nanbield" > > > > > > +DISTRO_CODENAME = "scarthgap" > > > > > > SDK_VENDOR = "-pokysdk" > > > > > > SDK_VERSION = "${@d.getVar('DISTRO_VERSION').replace('snapshot- > > ${METADATA_REVISION}', 'snapshot')}" > > > > > > SDK_VERSION[vardepvalue] = "${SDK_VERSION}" > > > > > > > > > -- > > - Thou shalt not follow the NULL pointer, for chaos and madness await > > thee at its end > > - "Use the force Harry" - Gandalf, Star Trek II -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II