Re: [master][scarthgap][poky][PATCH] rootfs-postcommands.bbclass: Only set DROPBEAR_RSAKEY_DIR once

Alexander Kanavin <[email protected]>
Newsgroups org.yoctoproject.lists.poky
Message-ID <CANNYZj_90xB+ZiBvU0B+KPP2pcb3vdtAPVPNpYnk8990Zn9z6A@mail.gmail.com>
Incorrect mailing list. Please read poky/README.md

Alex

On Mon, 22 Apr 2024 at 15:56, Michael Glembotzki via
lists.yoctoproject.org <[email protected]>
wrote:
>
> If DROPBEAR_RSAKEY_DIR has already been set before, e.g. by overwriting
> the file dropbear.default, the line will still be appended a second time.
>
> DROPBEAR_RSAKEY_DIR="/path/to/dropbear"
> DROPBEAR_EXTRA_ARGS="-B"
> DROPBEAR_RSAKEY_DIR=/var/lib/dropbear
>
> Signed-off-by: Michael Glembotzki <[email protected]>
> ---
>  meta/classes-recipe/rootfs-postcommands.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/rootfs-postcommands.bbclass b/meta/classes-recipe/rootfs-postcommands.bbclass
> index e81b69a239..920da94ba2 100644
> --- a/meta/classes-recipe/rootfs-postcommands.bbclass
> +++ b/meta/classes-recipe/rootfs-postcommands.bbclass
> @@ -206,7 +206,9 @@ read_only_rootfs_hook () {
>                 # Also tweak the key location for dropbear in the same way.
>                 if [ -d ${IMAGE_ROOTFS}/etc/dropbear ]; then
>                         if [ ! -e ${IMAGE_ROOTFS}/etc/dropbear/dropbear_rsa_host_key ]; then
> -                               echo "DROPBEAR_RSAKEY_DIR=/var/lib/dropbear" >> ${IMAGE_ROOTFS}/etc/default/dropbear
> +                               if ! grep -q "^DROPBEAR_RSAKEY_DIR=" ${IMAGE_ROOTFS}/etc/default/dropbear ; then
> +                                       echo "DROPBEAR_RSAKEY_DIR=/var/lib/dropbear" >> ${IMAGE_ROOTFS}/etc/default/dropbear
> +                               fi
>                         fi
>                 fi
>         fi
> --
> 2.44.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#13331): https://lists.yoctoproject.org/g/poky/message/13331
> Mute This Topic: https://lists.yoctoproject.org/mt/105669771/1686489
> Group Owner: [email protected]
> Unsubscribe: https://lists.yoctoproject.org/g/poky/unsub [[email protected]]
> -=-=-=-=-=-=-=-=-=-=-=-
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.