Re: [poky] [PATCH] local.conf.sample: update IMAGE_FEATURES comments to remove debug-tweaks

Hi Ross,

On Thu, Nov 07 2024 at 13:48 +0000, "Ross Burton" <[email protected]> wrote:
> Remove debug-tweaks and add the features that it included.
>
> Signed-off-by: Ross Burton <[email protected]>
> ---
>  .../conf/templates/default/local.conf.sample  | 36 +++++++++----------
>  1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/meta-poky/conf/templates/default/local.conf.sample b/meta-poky/conf/templates/default/local.conf.sample
> index cfa77106ab3..02aa3f238f2 100644
> --- a/meta-poky/conf/templates/default/local.conf.sample
> +++ b/meta-poky/conf/templates/default/local.conf.sample
> @@ -125,24 +125,24 @@ DISTRO ?= "poky"
>  # Extra image configuration defaults
>  #
>  # The EXTRA_IMAGE_FEATURES variable allows extra packages to be added to the generated
> -# images. Some of these options are added to certain image types automatically. The
> -# variable can contain the following options:
> -#  "dbg-pkgs"       - add -dbg packages for all installed packages
> -#                     (adds symbol information for debugging/profiling)
> -#  "src-pkgs"       - add -src packages for all installed packages
> -#                     (adds source code for debugging)
> -#  "dev-pkgs"       - add -dev packages for all installed packages
> -#                     (useful if you want to develop against libs in the image)
> -#  "ptest-pkgs"     - add -ptest packages for all ptest-enabled packages
> -#                     (useful if you want to run the package test suites)
> -#  "tools-sdk"      - add development tools (gcc, make, pkgconfig etc.)
> -#  "tools-debug"    - add debugging tools (gdb, strace)
> -#  "eclipse-debug"  - add Eclipse remote debugging support

the patch removes "eclipse-debug" as well. Was that intended?

Best regards
Ulrich


> -#  "tools-profile"  - add profiling tools (oprofile, lttng, valgrind)
> -#  "tools-testapps" - add useful testing tools (ts_print, aplay, arecord etc.)
> -#  "debug-tweaks"   - make an image suitable for development
> -#                     e.g. ssh root access has a blank password
> -# There are other application targets that can be used here too, see
> +# images. Some of these options are added to certain image types automatically. Some
> +# of the features available are:
> +#  "dbg-pkgs"             - add -dbg packages for all installed packages
> +#                           (adds symbol information for debugging/profiling)
> +#  "src-pkgs"             - add -src packages for all installed packages
> +#                           (adds source code for debugging)
> +#  "dev-pkgs"             - add -dev packages for all installed packages
> +#                           (useful if you want to develop against libs in the image)
> +#  "ptest-pkgs"           - add -ptest packages for all ptest-enabled packages
> +#                           (useful if you want to run the package test suites)
> +#  "tools-sdk"            - add development tools (gcc, make, pkgconfig etc.)
> +#  "tools-debug"          - add debugging tools (gdb, strace)
> +#  "tools-profile"        - add profiling tools (oprofile, lttng, valgrind)
> +#  "tools-testapps"       - add useful testing tools (ts_print, aplay, arecord etc.)
> +#  "allow-empty-password" - allow users to have an empty password
> +#  "empty-root-password"  - the root user has no password set
> +#  "allow-root-login      - the root user can login
> +# There are other features that can be used here too, see
>  # meta/classes-recipe/image.bbclass and
>  # meta/classes-recipe/core-image.bbclass for more details.
>  # We default to allowing root login without a password for convenience.
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |