Re: [poky] [PATCH] Check if version is actually a file

Thanks for the patch, but it should be sent to openembedded-core list,
as poky is an aggregate repository of various pieces.

Alex

On Fri, 14 Mar 2025 at 15:46, Frederik Brændstrup via
lists.yoctoproject.org
<[email protected]> wrote:
>
> Recipetool incorrectly made the assumption that version is always a
> file, but when it's a directory, the call to open fails
>
> Signed-off-by: Frede Braendstrup <[email protected]>
> ---
>  scripts/lib/recipetool/create_buildsys.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/lib/recipetool/create_buildsys.py b/scripts/lib/recipetool/create_buildsys.py
> index ec9d510e23..0a08fc64ca 100644
> --- a/scripts/lib/recipetool/create_buildsys.py
> +++ b/scripts/lib/recipetool/create_buildsys.py
> @@ -808,6 +808,8 @@ class VersionFileRecipeHandler(RecipeHandler):
>              version = None
>              for fileitem in filelist:
>                  linecount = 0
> +                if not os.path.isfile(fileitem):
> +                    continue
>                  with open(fileitem, 'r', errors='surrogateescape') as f:
>                      for line in f:
>                          line = line.rstrip().strip('"\'')
> --
> 2.47.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#13567): https://lists.yoctoproject.org/g/poky/message/13567
> Mute This Topic: https://lists.yoctoproject.org/mt/111700337/1686489
> Group Owner: [email protected]
> Unsubscribe: https://lists.yoctoproject.org/g/poky/unsub [[email protected]]
> -=-=-=-=-=-=-=-=-=-=-=-
>