Re: [poky] [PATCH 2/4] conf/fragments: add fragments for qemux86-64 and qemuarm64

Richard Purdie <[email protected]> Tue, 03 Jun 2025 20:48:12 +0100
Newsgroups org.yoctoproject.lists.poky
Message-ID <b8f9ba8524090623e0e13ef36724839c140f99a6.camel@linuxfoundation.org>
On Tue, 2025-06-03 at 13:35 +0200, Alexander Kanavin via lists.yoctoproject.org wrote:
> From: Alexander Kanavin <[email protected]>
> 
> These will be used by official bitbake-setup configurations,
> and so let's start with them :) Plenty more fragments can
> be added over time.
> 
> Signed-off-by: Alexander Kanavin <[email protected]>
> ---
>  meta/conf/fragments/machines/qemuarm64.conf  | 5 +++++
>  meta/conf/fragments/machines/qemux86-64.conf | 5 +++++
>  2 files changed, 10 insertions(+)
>  create mode 100644 meta/conf/fragments/machines/qemuarm64.conf
>  create mode 100644 meta/conf/fragments/machines/qemux86-64.conf
> 
> diff --git a/meta/conf/fragments/machines/qemuarm64.conf b/meta/conf/fragments/machines/qemuarm64.conf
> new file mode 100644
> index 00000000000..0fc164541d5
> --- /dev/null
> +++ b/meta/conf/fragments/machines/qemuarm64.conf
> @@ -0,0 +1,5 @@
> +BB_CONF_FRAGMENT_SUMMARY = "Use qemuarm64 as a target MACHINE, suitable for running in QEMU system emulator."
> +BB_CONF_FRAGMENT_DESCRIPTION = "Select qemuarm64 as the target machine. This is the best option for running the target system inside QEMU emulator on arm64 build hosts, \
> +as it allows near-native performance with kvm acceleration. Also useful for testing arm64 specific assembly code or compiler output."
> +
> +MACHINE ?= "qemuarm64"
> diff --git a/meta/conf/fragments/machines/qemux86-64.conf b/meta/conf/fragments/machines/qemux86-64.conf
> new file mode 100644
> index 00000000000..0fce37c4e2e
> --- /dev/null
> +++ b/meta/conf/fragments/machines/qemux86-64.conf
> @@ -0,0 +1,5 @@
> +BB_CONF_FRAGMENT_SUMMARY = "Use qemux86-64 as a target MACHINE, suitable for running in QEMU system emulator."
> +BB_CONF_FRAGMENT_DESCRIPTION = "Select qemux86-64 as the target machine. This is the best option for running the target system inside QEMU emulator on x86-64 build hosts, \
> +as it allows near-native performance with kvm acceleration. Also useful for testing x86-64 specific assembly code or compiler output."
> +
> +MACHINE ?= "qemux86-64"

What bothers me about this is that we have multiple files, each with a
single similar config line in them. It implies we need to create a new
machine config fragment for every machine, which to be honest, is
madness.

Would it be better if the config/setup code understood what something
like "machine/qemux86-64" or "distro/poky" meant and did something
magic with that?

Cheers,

Richard