Re: Toaster enhancement set posted

"Reyna, David" <[email protected]>
Newsgroups org.yoctoproject.lists.toaster
Message-ID <[email protected]>
Hi Richard,

I have been doing additional testing, and will have the post for you this week.

After that, I have a patch set from Awais Belal that I am testing, and will merge on top of the current work and then submit that.

Thank you for asking!
David

-----Original Message-----
From: Richard Purdie [mailto:[email protected]] 
Sent: Monday, July 16, 2018 10:00 AM
To: Reyna, David; [email protected]
Subject: Re: [Toaster] Toaster enhancement set posted

Hi David,

On Fri, 2018-06-29 at 08:37 +0000, Reyna, David wrote:
> We have found one small glitch. I will repost an adjusted patch
> tomorrow.
> 
> Normally a new project has only a "Prepare" button to close the
> configure page, as opposed to a "Update" and a "Cancel" button. The
> "Cancel" button is hidden to insure that new projects pass through
> the clone phase before closing so that the project would be buildable
> with all layers accounted for. 
> 
> The observed error is that only the main configure page had that
> button substitution, because the flag was not passed into the global
> context.
> 
> The fix is to add a helper method "get_is_new" to the "Project" model
> in order to make this variable always available to
> "project_specific_topbar.html".

Did you repost a new version of this somewhere? I'm happy to merge but
not sure I have the right version in -next.

A pointer to the correct patch would be useful!

Cheers,

Richard
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.