Re: [bitbake-devel] [PATCH 1/1] toaster:update selenium version and code syntax

On Tue, 2023-10-03 at 13:26 -0400, Marlon Rodriguez Garcia wrote:
> Updated selenium version to latest 4.13.0, changed selenum specific version syntax elements to accomplish test success
> 
> Signed-off-by: Marlon Rodriguez Garcia <[email protected]>
> ---
>  lib/toaster/orm/models.py                     |   2 +-
>  .../tests/browser/selenium_helpers_base.py    |   9 +-
>  .../tests/browser/test_all_builds_page.py     |  26 ++--
>  .../tests/browser/test_all_projects_page.py   |  14 +-
>  .../tests/browser/test_builddashboard_page.py |  10 +-
>  .../browser/test_most_recent_builds_states.py |  12 +-
>  .../browser/test_new_custom_image_page.py     |   4 +
>  .../tests/browser/test_new_project_page.py    |  12 +-
>  .../tests/browser/test_project_config_page.py |  29 +++--
>  .../tests/browser/test_toastertable_ui.py     |   7 +-
>  .../tests/builds/test_core_image_min.py       |   1 +
>  .../tests/functional/functional_helpers.py    |  21 +--
>  .../tests/functional/test_functional_basic.py | 120 +++++++++---------
>  .../tests/toaster-tests-requirements.txt      |   2 +-
>  lib/toaster/tests/views/test_views.py         |   4 +
>  lib/toaster/toastergui/widgets.py             |   1 +
>  16 files changed, 156 insertions(+), 118 deletions(-)

At a quick glance this seems reasonable to me but I'm far from an
expert in this area. I've realised that for toaster patches you should
copy the toaster mailing list as well. I'll likely wait a short while
for feedback then merge if there isn't any. At this point our automated
testing won't cover anything here but I know we plan to change that!

Cheers,

Richard