Re: [bitbake-devel] [Toaster] [PATCH] toaster: Added dataTables library to include sorting and pagination for table element

The image missing is a version issue, i will update with a new patch with the latest version, the default value of entries for page  in the table seems correct , i will include that on the patch as well.
In relation to the queue i will work on that in a different patch 

----- Original Message -----
From: "richard purdie" <[email protected]>
To: "Marlon Rodriguez Garcia" <[email protected]>, "bitbake-devel" <[email protected]>, "toaster" <[email protected]>
Sent: Wednesday, December 13, 2023 8:11:06 AM
Subject: Re: [bitbake-devel] [Toaster] [PATCH] toaster: Added dataTables library to include sorting and pagination for table element

On Tue, 2023-12-12 at 16:57 -0500, Marlon Rodriguez Garcia wrote:
> Added jquery.dataTables to customize table rendering in section
> "Import eventlogs".
> This library includes the following: sorting, pagination, search and
> CSS styles.

Thanks, this looks good. I noticed that there are a couple of static
images missing:

http://localhost:8000/static/images/sort_asc.png
http://localhost:8000/static/images/sort_both.png

I also wondered about something like this:

diff --git a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
index 25a5e8062fb..c9fefef01a2 100644
--- a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
+++ b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
@@ -197,7 +197,7 @@ $( "#form_file").on( "submit", function( event ) {
 });
 
 $(document).ready( function () {
-    $('#eventlog-table').DataTable();
+    $('#eventlog-table').DataTable({order: [[0, 'desc']], "pageLength": 50})
 });
 
 </script>

to set the default sort and show a few more file entries per page. Not
sure if I have that in the right place!

I did also realise the issue I was trying to explain yesterday.

If you start an import of a commandline build, then try and import a
second one whilst the first is still running, it crashes. Is there
something we can do about that so they queue?

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15659): https://lists.openembedded.org/g/bitbake-devel/message/15659
Mute This Topic: https://lists.openembedded.org/mt/103148397/7896800
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/leave/12674656/7896800/2042766072/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-