[PATCH v3 2/5] toaster/test: Handle ProcessLookupError, log warning in console

Alassane Yattara <[email protected]> Fri, 15 Dec 2023 10:39:16 +0100
Newsgroups org.yoctoproject.lists.toaster
Message-ID <[email protected]>
Note: While addressing warnings on the autobuilder, we encountered releva=
nt warnings
where attempts were made to terminate processes that were not running.

To enhance visibility, we have opted to catch the ProcessLookupError exce=
ption
and log a warning in the console rather than suppressing it.

Signed-off-by: Alassane Yattara <[email protected]>
---
 lib/toaster/tests/commands/test_runbuilds.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/toaster/tests/commands/test_runbuilds.py b/lib/toaster/t=
ests/commands/test_runbuilds.py
index 738d36e9..849c227e 100644
--- a/lib/toaster/tests/commands/test_runbuilds.py
+++ b/lib/toaster/tests/commands/test_runbuilds.py
@@ -22,8 +22,6 @@ import signal
 import logging
=20
=20
-logger =3D logging.getLogger("toaster")
-
 class KillRunbuilds(threading.Thread):
     """ Kill the runbuilds process after an amount of time """
     def __init__(self, *args, **kwargs):
@@ -43,7 +41,7 @@ class KillRunbuilds(threading.Thread):
                 pid =3D pidfile.read()
                 os.kill(int(pid), signal.SIGTERM)
         except ProcessLookupError:
-            logger.warning("Runbuilds not running or already killed")
+            logging.warning("Runbuilds not running or already killed")
=20
=20
 class TestCommands(TestCase):
--=20
2.34.1