[PATCH 1/4] toaster/test: bug-fix An element matching "#projectstable" should be visible

Signed-off-by: Alassane Yattara <[email protected]>
---
 .../tests/browser/selenium_helpers_base.py    |  2 +
 .../tests/functional/test_functional_basic.py | 87 ++++++++++---------
 2 files changed, 46 insertions(+), 43 deletions(-)

diff --git a/lib/toaster/tests/browser/selenium_helpers_base.py b/lib/toa=
ster/tests/browser/selenium_helpers_base.py
index 13806624..562fedec 100644
--- a/lib/toaster/tests/browser/selenium_helpers_base.py
+++ b/lib/toaster/tests/browser/selenium_helpers_base.py
@@ -206,6 +206,8 @@ class SeleniumTestCaseBase(unittest.TestCase):
         is_present =3D lambda driver: self.find(selector)
         msg =3D 'An element matching "%s" should be on the page' % selec=
tor
         element =3D Wait(self.driver, poll=3Dpoll).until(is_present, msg=
)
+        if poll > 2:
+            time.sleep(poll)  # element need more delay to be present
         return element
=20
     def wait_until_visible(self, selector, poll=3D1):
diff --git a/lib/toaster/tests/functional/test_functional_basic.py b/lib/=
toaster/tests/functional/test_functional_basic.py
index 47f7452e..e4070fbb 100644
--- a/lib/toaster/tests/functional/test_functional_basic.py
+++ b/lib/toaster/tests/functional/test_functional_basic.py
@@ -14,15 +14,27 @@ from tests.functional.functional_helpers import Selen=
iumFunctionalTestCase
 from orm.models import Project
 from selenium.webdriver.common.by import By
=20
+from tests.functional.utils import get_projectId_from_url
=20
+
[email protected]_db
 @pytest.mark.order("second_to_last")
 class FuntionalTestBasic(SeleniumFunctionalTestCase):
+    """Basic functional tests for Toaster"""
+    project_id =3D None
+
+    def setUp(self):
+        super(FuntionalTestBasic, self).setUp()
+        if not FuntionalTestBasic.project_id:
+            self._create_slenium_project()
+            current_url =3D self.driver.current_url
+            FuntionalTestBasic.project_id =3D get_projectId_from_url(cur=
rent_url)
=20
 #   testcase (1514)
-    @pytest.mark.django_db
-    def test_create_slenium_project(self):
+    def _create_slenium_project(self):
         project_name =3D 'selenium-project'
         self.get(reverse('newproject'))
+        self.wait_until_visible('#new-project-name', poll=3D3)
         self.driver.find_element(By.ID, "new-project-name").send_keys(pr=
oject_name)
         self.driver.find_element(By.ID, 'projectversion').click()
         self.driver.find_element(By.ID, "create-project-button").click()
@@ -32,69 +44,68 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase):
                         "New project name not in new project notificatio=
n")
         self.assertTrue(Project.objects.filter(name=3Dproject_name).coun=
t(),
                         "New project not found in database")
+        return Project.objects.last().id
=20
  #  testcase (1515)
     def test_verify_left_bar_menu(self):
         self.get(reverse('all-projects'))
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         self.assertTrue(self.element_exists('#config-nav'),'Configuratio=
n Tab does not exist')
         project_URL=3Dself.get_URL()
         self.driver.find_element(By.XPATH, '//a[@href=3D"'+project_URL+'=
"]').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'customimages/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Custom images",self.driver.find_e=
lement(By.XPATH, "//div[@class=3D'col-md-10']").text),'Custom images info=
rmation is not loading properly')
         except:
             self.fail(msg=3D'No Custom images tab available')
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'images/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Compatible image recipes",self.dr=
iver.find_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The Com=
patible image recipes information is not loading properly')
         except:
             self.fail(msg=3D'No Compatible image tab available')
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'softwarerecipes/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Compatible software recipes",self=
.driver.find_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The =
Compatible software recipe information is not loading properly')
         except:
             self.fail(msg=3D'No Compatible software recipe tab available=
')
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'machines/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Compatible machines",self.driver.=
find_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The Compatib=
le machine information is not loading properly')
         except:
             self.fail(msg=3D'No Compatible machines tab available')
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'layers/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Compatible layers",self.driver.fi=
nd_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The Compatible=
 layer information is not loading properly')
         except:
             self.fail(msg=3D'No Compatible layers tab available')
=20
         try:
             self.driver.find_element(By.XPATH, "//*[@id=3D'config-nav']/=
ul/li/a[@href=3D"+'"'+project_URL+'configuration"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Bitbake variables",self.driver.fi=
nd_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The Bitbake va=
riables information is not loading properly')
         except:
             self.fail(msg=3D'No Bitbake variables tab available')
=20
 #   testcase (1516)
     def test_review_configuration_information(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
         project_URL=3Dself.get_URL()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         try:
            self.assertTrue(self.element_exists('#machine-section'),'Mach=
ine section for the project configuration page does not exist')
            self.assertTrue(re.search("qemux86-64",self.driver.find_eleme=
nt(By.XPATH, "//span[@id=3D'project-machine-name']").text),'The machine t=
ype is not assigned')
@@ -134,12 +145,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase=
):
=20
 #   testcase (1517)
     def test_verify_machine_information(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
=20
         try:
             self.assertTrue(self.element_exists('#machine-section'),'Mac=
hine section for the project configuration page does not exist')
@@ -153,29 +162,25 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase=
):
=20
 #   testcase (1518)
     def test_verify_most_built_recipes_information(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         project_URL=3Dself.get_URL()
         try:
             self.assertTrue(re.search("You haven't built any recipes yet=
",self.driver.find_element(By.ID, "no-most-built").text),'Default message=
 of no builds is not present')
             self.driver.find_element(By.XPATH, "//div[@id=3D'no-most-bui=
lt']/p/a[@href=3D"+'"'+project_URL+'images/"'+"]").click()
-            self.wait_until_visible('#config-nav', poll=3D10)
+            self.wait_until_present('#config-nav', poll=3D10)
             self.assertTrue(re.search("Compatible image recipes",self.dr=
iver.find_element(By.XPATH, "//div[@class=3D'col-md-10']").text),'The Cho=
ose a recipe to build link  is not working  properly')
         except:
             self.fail(msg=3D'No Most built information in project detail=
 page')
=20
 #   testcase (1519)
     def test_verify_project_release_information(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
=20
         try:
             self.assertTrue(re.search("Yocto Project master",self.driver=
.find_element(By.ID, "project-release-title").text),'The project release =
is not defined')
@@ -184,12 +189,10 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase=
):
=20
 #   testcase (1520)
     def test_verify_layer_information(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         project_URL=3Dself.get_URL()
         try:
            self.driver.find_element(By.XPATH, "//div[@id=3D'layer-contai=
ner']")
@@ -216,15 +219,13 @@ class FuntionalTestBasic(SeleniumFunctionalTestCase=
):
=20
 #   testcase (1521)
     def test_verify_project_detail_links(self):
-        self.get('')
-        self.wait_until_visible('#global-nav', poll=3D10)
-        self.driver.find_element(By.XPATH, "//div[@id=3D'global-nav']/ul=
/li/a[@href=3D"+'"'+'/toastergui/projects/'+'"'+"]").click()
-        self.wait_until_visible('#projectstable', poll=3D10)
+        self.get(reverse('all-projects'))
+        self.wait_until_present('#projectstable', poll=3D10)
         self.find_element_by_link_text_in_table('projectstable', 'seleni=
um-project').click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         project_URL=3Dself.get_URL()
         self.driver.find_element(By.XPATH, "//div[@id=3D'project-topbar'=
]/ul[@class=3D'nav nav-tabs']/li[@id=3D'topbar-configuration-tab']/a[@hre=
f=3D"+'"'+project_URL+'"'+"]").click()
-        self.wait_until_visible('#config-nav', poll=3D10)
+        self.wait_until_present('#config-nav', poll=3D10)
         self.assertTrue(re.search("Configuration",self.driver.find_eleme=
nt(By.XPATH, "//div[@id=3D'project-topbar']/ul[@class=3D'nav nav-tabs']/l=
i[@id=3D'topbar-configuration-tab']/a[@href=3D"+'"'+project_URL+'"'+"]").=
text), 'Configuration tab in project topbar is misspelled')
=20
         try:
--=20
2.34.1